Set the User-Agent regardless of GET or POST #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mig5
force-pushed
the
setUserAgent-on-any-method
branch
from
7d26e83
to
4e9be02
Compare
ricklambrechts
approved these changes
Aug 1, 2023
Magentron
added a commit
to Magentron/OpenID-Connect-PHP
that referenced
this pull request
May 22, 2024
* upstream/master: fix: Removed duplicate check on jwks_uri and only check if jwks_uri exists when needed (jumbojett#373) fix: Check if subject is equal to subject of id token when verifying JWT claims (jumbojett#406) fix: Cast SERVER_PORT to integer (jumbojett#404) chore(deps): bump actions/cache from 3 to 4 (jumbojett#417) chore(deps): bump actions/checkout from 2 to 4 (jumbojett#416) docs: Update README.md to correct addScope parameter type in 1.0.0 (jumbojett#405) chore: Update ci to support php 8.3 and add dependabot (jumbojett#407) release: 1.0.0 (jumbojett#402) Set the User-Agent regardless of GET or POST (jumbojett#382) fix: Update well known config value function response types (jumbojett#376) feat: set useragent (jumbojett#370) feat: php7.0 minimum requirement (jumbojett#327) # Conflicts: # CHANGELOG.md
Magentron
added a commit
to Magentron/OpenID-Connect-PHP
that referenced
this pull request
May 22, 2024
…est-token * master: fix: Removed duplicate check on jwks_uri and only check if jwks_uri exists when needed (jumbojett#373) fix: Check if subject is equal to subject of id token when verifying JWT claims (jumbojett#406) fix: Cast SERVER_PORT to integer (jumbojett#404) chore(deps): bump actions/cache from 3 to 4 (jumbojett#417) chore(deps): bump actions/checkout from 2 to 4 (jumbojett#416) docs: Update README.md to correct addScope parameter type in 1.0.0 (jumbojett#405) chore: Update ci to support php 8.3 and add dependabot (jumbojett#407) release: 1.0.0 (jumbojett#402) Set the User-Agent regardless of GET or POST (jumbojett#382) fix: Update well known config value function response types (jumbojett#376) feat: set useragent (jumbojett#370) feat: php7.0 minimum requirement (jumbojett#327) updated composer.json added replace, updated README.md added notification about project forked from # Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am working with an OP that rejects the GET request to
/.well-known/openid-configurationbecause the User-Agent is null.Rather than only set the User-Agent only on POST requests, always send it (so it works for GET as well).
List of common tasks a pull request require complete