Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use composer in container #1

Open
brettp opened this issue Mar 16, 2015 · 0 comments
Open

Don't use composer in container #1

brettp opened this issue Mar 16, 2015 · 0 comments

Comments

@brettp
Copy link
Collaborator

brettp commented Mar 16, 2015

Currently composer is installed in the Dockerfile and called from the container's run.sh script. There are a few problems with this:

  1. It assumes you want the container to manage vendors.
  2. It goes against the philosophy of separating tools to manage code from code itself.
  3. It causes a sometimes significant delay during startup.

I'm bringing this up because the point of Docker is to run an app with the user not having to worry about external deps. If we drop composer, we'd have to expect the user to have a working Elgg installation means the user either needs to download a release of Elgg that's already composed, or have composer and its reqs installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant