-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release another update? #57
Comments
Try add this repo in your composer.json to download the package directly from GitHub
|
@jumbojett We need to decide version number that we will use for new release. Composer recommends using Semantic Versioning(http://semver.org/). A version number below 1.0.0 indicate that your are developing project. (And may break backward compatibility from one version to another without changing Major number in version number) We are currently released as version 0.1.0 If you think that you don't need to make backward incompatible changes frequently, then we should bump up the version number to 1.0.0(I would suggest that we should try to make the package PSR4(http://www.php-fig.org/psr/psr-4/) complaint before releasing version 1.0.0. Making it PSR4 will break backward compatibility.) If we do however start to use version number 1.0.0, then all version numbers for future releases will need to follow semver conversion. Major.Minor.Patch
Let me know if you want to increase version number to 1.0.0 |
Hi @frank-herbert, You can simply do |
We've needed versioning for a while. @rasodu I appreciate the initiative. I see this as priority and I don't want to be a bottleneck in this effort. You're welcome to create and accept PRs without my review. What you've described above aligns with what I'm thinking.
Yes 👍
I'm fine with this. |
How should we go about petitioning for the marking of a new release (in packagist)? Indefinitely using dev-master in composer isn't a viable solution |
As @Harkenn as already alluded to, using dev-master in composer for projects using this library on production servers is just asking for serious problems, so could we please get a new release containing the bug fixes and extra functionality since v0.2.0? |
Version 0.3.0 is released. We need to add changelog file for for the project(http://keepachangelog.com/en/0.3.0/). @kenguest can you make a pull request to create the file. Also if you can add a note in readme that all the future pull request should add an entry to this file so we know how to increment the version. |
Version 0.3.0 is not showing up on packagist [yet] - https://packagist.org/packages/jumbojett/openid-connect-php ... |
Fixed. It is now showing up. |
As requested by @rasodu at jumbojett#57 (comment)
As requested by @rasodu at jumbojett#57 (comment)
Those multiple commits should not have happened - first time doing a PR through the github website rather than the command line and it seems to have... been a unique experience. Apologies for that. |
I think we need to break #80 into multiple pull request
|
I'm happy to help with this effort. I have a lot of experience with moving packages towards PSR compliance and developing releases. See league/oauth2-client contributions. |
@shadowhand I'm all for collaboration! |
@shadowhand Current class is not namespaced. I think next step should be to add namespace to the class. Can you create a new pull request for this? This will have few ramifications(Mainly BC break). We will discuss them further in the pull request. @jumbojett @kenguest @shadowhand We need to decide the name we will use for namespace. @shadowhand will need it to kick off the effort. Does anyone have suggestion? We can use 'Jumbojett\OpenIDConnectPHP' or 'Jumbojett\OpenIDConnect'. |
I would strongly suggest not using a person as the root namespace. I think |
@rasodu I vote for
@shadowhand could you elaborate? I can see where it would appear more official, but without a github organization or domain, I fear it might mislead. |
@jumbojett Composer includes a The problem with using a person as the root namespace is if it gets abandoned, everyone is going to have to update their composer references and there is more friction. Using an organization, even if it currently points to a personal Github page, is safer in the long run because it allows changing the target repository with minimal effort and no effort on the part of users. This is why my package Also worth noting that the org |
I value your expertise and input @shadowhand. I also understand your reasoning. This repo has been active for almost 5 years. People in the OIDC community link here for support and references. Our library is focused on minimalism. (one single php file) In a way, I feel like not having an organization reflects that. @rasodu let's roll with with the |
@jumbojett - as you say, people link. You could simply link from Jumbojett\OpenID-Connect-PHP repo to a superseding repository. Take a look at https://github.com/manuelpichler/phpmd - this is what happened there. Similarly the official repo for PEAR's Auth_SASL2 repo is at https://github.com/pear/Auth_SASL2 - not the original author's repo at https://github.com/CloCkWeRX/Auth_SASL2. Links can be updated, redirections can be put in place. Also if the project does become PSR2 compliant then you won't have just one single PHP file anymore, so your point there is moot to be honest. |
I'd like to make sure we distinguish our library from others. There's already other php OIDC libraries that are PSR2 compliant and more for the individual who wants something that conforms to a standard. (https://github.com/ivan-novakov/php-openid-connect-client) The goal of this project is readability and minimalism. Less dependencies and less code. That said... Maybe incorporate some of @kdoyen 's changes / tests as well? |
@shadowhand I've been thinking about your proposal. If you would like to take the initiative to create the organization and import the PSR2 compliance work currently in progress then let's run with it. Steps:
This project could benefit from your expertise. Feel free to email me directly if you have questions. |
@jumbojett I dropped the ball here. My interest in working on this package was based on a work need. The project has changed and we will no longer be using OpenID. If something changes in the future, I will happily contribute to this package. Apologies for the late response. 😞 |
@shadowhand no worries! Thank you for the update. If something changes, please let us know. |
Inviting @guss77 to the discussion. |
Thanks @jumbojett - I'm happy to be involved. I'm currently maintaining a fork at https://github.com/con-tools/Auth-OpenID-Connect where some PSR-1 was done, in addition to some minor API changes. I'm interested in completing more PSR-1/2/4 work, before maybe discussing opening the API a bit for extension. The next thing on @rasodu list is adding the top level |
Regarding the merging existing PRs before merging the PSR-2 work, I'm willing to review and fix merge conflicts for any existing PR that there is interest in still completing. @jumbojett - if you have time to review existing PRs, close what you are not interested in merging and pinging me on any that you are, I'll review and fix what is still open. |
@guss77 I just gave you collaborative access to the repo. You are welcome to review and merge as necessary! |
Hello,
Is it possible to release another composer update for this? Looks like its been a while and there are some good changes in the code :)
The text was updated successfully, but these errors were encountered: