Refactor QP with MatrixOfConstraints and bridges #187
Conversation
|
Current failures are mostly due to: |
Fixed by 93d286c |
| MOIU.UniversalFallback(MOIU.Model{Float64}()), | ||
| optimizer, | ||
| ) | ||
| return Optimizer(caching_opt) |
There was a problem hiding this comment.
Should we recommend:
DiffOpt.diff_optimizer for pure MOI usage
and
DiffOpt.Optimizer for JuMP usage?
There was a problem hiding this comment.
We should recommend DiffOpt.diff_optimizer in both cases. Optimizer is for advanced user that want to control the caches and bridges layers, similar to the direct mode in JuMP.
Codecov Report
@@ Coverage Diff @@
## master #187 +/- ##
==========================================
- Coverage 89.40% 88.17% -1.23%
==========================================
Files 8 8
Lines 934 837 -97
==========================================
- Hits 835 738 -97
Misses 99 99
Continue to review full report at Codecov.
|
|
Is this blocked by a merge on MOI? I saw the special branch in the docs |
Yes, the MOI |
|
@blegat we can now change the dependency to MOI 0.10.8 and remove the branch specification in CI :) |
@blegat I would just crank up the tolerance here no? |
Requires
MOI#bl/diffoptin the Github actions toMOI#master.MOI#master.bridged_functionandunbridged_functiondon't treat the function as a derivative hence they will add constants :/)Closes #153
Closes #167