Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version check and error message #152

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Update version check and error message #152

merged 1 commit into from
Sep 28, 2020

Conversation

odow
Copy link
Member

@odow odow commented Sep 25, 2020

We should check the user's binary version, instead of the version in libglpk_common.jl...

@codecov
Copy link

codecov bot commented Sep 25, 2020

Codecov Report

Merging #152 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #152      +/-   ##
==========================================
+ Coverage   85.39%   85.46%   +0.07%     
==========================================
  Files           8        8              
  Lines        1390     1390              
==========================================
+ Hits         1187     1188       +1     
+ Misses        203      202       -1     
Impacted Files Coverage Δ
src/GLPK.jl 100.00% <ø> (ø)
src/gen/libglpk_api.jl 68.18% <0.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb9d425...bf27b7a. Read the comment docs.

@odow odow merged commit 33c6f6e into master Sep 28, 2020
@odow odow deleted the od/version branch September 28, 2020 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants