Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing == in MOI_wrapper assertions #106

Closed
grahamgill opened this issue Apr 3, 2022 · 0 comments · Fixed by #107
Closed

Missing == in MOI_wrapper assertions #106

grahamgill opened this issue Apr 3, 2022 · 0 comments · Fixed by #107
Assignees
@odow

Comments

@grahamgill
Copy link

HiGHS.jl/src/MOI_wrapper.jl

Line 1705 in 8e39503

@assert model.solution.model_status kHighsModelStatusUnknown

Also at

HiGHS.jl/src/MOI_wrapper.jl

Line 1653 in 8e39503

@assert model.solution.model_status kHighsModelStatusUnknown

I only noticed this after making the change I mentioned in #105, since Highs_run warnings were now going through the if..else lists in MOI.get(..., ::MOI.TerminationStatus) and MOI.get(..., ::MOI.RawStatusString) and erroring on the malformed assertions, with TypeError: non-boolean used in boolean context.
@odow odow mentioned this issue Apr 3, 2022
Merged
@odow odow self-assigned this Apr 3, 2022
@odow odow closed this as completed in #107 Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odow odow

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix missing == in asserts jump-dev/HiGHS.jl
2 participants
@odow @grahamgill