Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HiGHS v1.7.0 #205

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Support HiGHS v1.7.0 #205

merged 2 commits into from
Mar 7, 2024

Conversation

odow
Copy link
Member

@odow odow commented Mar 7, 2024

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 83.42%. Comparing base (0bd029b) to head (18248fe).

Files Patch % Lines
src/gen/libhighs.jl 0.00% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #205      +/-   ##
==========================================
- Coverage   84.30%   83.42%   -0.89%     
==========================================
  Files           3        3              
  Lines        1695     1713      +18     
==========================================
  Hits         1429     1429              
- Misses        266      284      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -13,18 +13,30 @@ struct HighsCallbackDataOut
running_time::Cdouble
simplex_iteration_count::HighsInt
ipm_iteration_count::HighsInt
pdlp_iteration_count::HighsInt
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @jajhall adding a field to the middle of a struct is technically breaking, but I don't think it really matters in this case because no one was really using the callbacks yet.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, fair cop, well spotted!

@odow odow merged commit 7d888be into master Mar 7, 2024
8 of 10 checks passed
@odow odow deleted the odow-patch-1 branch March 7, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

HiGHS v1.7
2 participants