Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix printing with Unitful coefficient #1352

Merged
merged 3 commits into from
Jun 21, 2018
Merged

Fix printing with Unitful coefficient #1352

merged 3 commits into from
Jun 21, 2018

Conversation

blegat
Copy link
Member

@blegat blegat commented Jun 19, 2018

This is needed for the printing in #1350 to actually work :-P

@codecov
Copy link

codecov bot commented Jun 19, 2018

Codecov Report

Merging #1352 into master will decrease coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1352     +/-   ##
=========================================
- Coverage   89.34%   89.25%   -0.1%     
=========================================
  Files          24       24             
  Lines        3388     3647    +259     
=========================================
+ Hits         3027     3255    +228     
- Misses        361      392     +31
Impacted Files Coverage Δ
src/print.jl 80.51% <100%> (+1.06%) ⬆️
src/variables.jl 85.88% <0%> (-2.75%) ⬇️
src/Derivatives/coloring.jl 97.57% <0%> (-0.12%) ⬇️
src/JuMP.jl 79.03% <0%> (+0.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75258ea...c9594a1. Read the comment docs.

@mlubin
Copy link
Member

mlubin commented Jun 19, 2018

Could you add a test for this? It's not immediately clear what the issue was.

@blegat blegat merged commit 13d109a into master Jun 21, 2018
@blegat blegat deleted the bl/printunit branch June 29, 2018 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants