Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MA.Zero in objective and constraints #2219

Merged
merged 2 commits into from
Apr 7, 2020
Merged

Support MA.Zero in objective and constraints #2219

merged 2 commits into from
Apr 7, 2020

Conversation

odow
Copy link
Member

@odow odow commented Apr 3, 2020

Closes #2087

@odow
Copy link
Member Author

odow commented Apr 3, 2020

@blegat did that latest tag of MA break these tests?

@odow
Copy link
Member Author

odow commented Apr 3, 2020

Failing tests will be fixed with jump-dev/MutableArithmetics.jl#46.

@odow odow closed this Apr 6, 2020
@odow odow reopened this Apr 6, 2020
@codecov
Copy link

codecov bot commented Apr 6, 2020

Codecov Report

Merging #2219 into master will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2219      +/-   ##
==========================================
- Coverage   91.11%   91.06%   -0.05%     
==========================================
  Files          42       42              
  Lines        4130     4208      +78     
==========================================
+ Hits         3763     3832      +69     
- Misses        367      376       +9     
Impacted Files Coverage Δ
src/macros.jl 92.65% <100.00%> (+0.01%) ⬆️
src/objective.jl 91.66% <100.00%> (+0.23%) ⬆️
src/JuMP.jl 77.68% <0.00%> (+3.12%) ⬆️
src/sets.jl 94.73% <0.00%> (+9.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6017d7b...c94a9b2. Read the comment docs.

src/macros.jl Outdated Show resolved Hide resolved
@odow odow merged commit c4596a8 into master Apr 7, 2020
@odow odow deleted the od/MA.Zero branch April 7, 2020 02:53
@blegat blegat added this to the 0.21.3 milestone Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Error message with Val{false}
2 participants