Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_bounds to Utilities #890

Merged
merged 5 commits into from
Sep 25, 2019
Merged

Add get_bounds to Utilities #890

merged 5 commits into from
Sep 25, 2019

Conversation

joehuchette
Copy link
Contributor

Computes variable lower/upper bounds set on a MOI variable

Copy link
Member

@odow odow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's valid to have separate lessthan AND greaterthan constraints. It's not an OR.

@codecov-io
Copy link

codecov-io commented Sep 20, 2019

Codecov Report

Merging #890 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #890      +/-   ##
==========================================
+ Coverage    95.1%   95.16%   +0.06%     
==========================================
  Files          80       81       +1     
  Lines        8481     9332     +851     
==========================================
+ Hits         8066     8881     +815     
- Misses        415      451      +36
Impacted Files Coverage Δ
src/Utilities/Utilities.jl 100% <ø> (ø) ⬆️
src/Utilities/variables.jl 100% <100%> (ø)
src/Bridges/Constraint/scalarize.jl 77.55% <0%> (-2.45%) ⬇️
src/Utilities/model.jl 94.64% <0%> (-0.26%) ⬇️
src/Test/UnitTests/solve.jl 100% <0%> (ø) ⬆️
src/Utilities/copy.jl 94.66% <0%> (+0.02%) ⬆️
src/Utilities/functions.jl 94.06% <0%> (+0.05%) ⬆️
src/Bridges/bridge_optimizer.jl 95.75% <0%> (+0.15%) ⬆️
src/Test/modellike.jl 99.27% <0%> (+0.21%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 178c3aa...d774fda. Read the comment docs.

@blegat
Copy link
Member

blegat commented Sep 20, 2019

What about MOI.EqualTo, if it's set we could return both bounds equal to the value of the set.

@joehuchette
Copy link
Contributor Author

But it's invalid to have an Interval AND a GreaterThan, correct?

@odow
Copy link
Member

odow commented Sep 20, 2019

But it's invalid to have an Interval AND a GreaterThan, correct?

Yes. Here are the options:

  • Interval
  • LessThan
  • GreaterThan
  • EqualTo
  • LessThan AND GreaterThan
  • Semicontinuous
  • Semiinteger

@joehuchette joehuchette merged commit 566d797 into master Sep 25, 2019
@odow odow deleted the get_bounds branch December 5, 2019 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants