[breaking] Remove the Allocate-Load API #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This API was confusing, never widely used, and didn't support bridges.
blegat
reviewed
Jul 26, 2021
|
So yay/nay on this? |
blegat
reviewed
Jul 29, 2021
| elseif supports_allocate_load(dest, copy_names) | ||
| return allocate_load(dest, src, copy_names, filter_constraints) | ||
| else | ||
| if !MOI.supports_incremental_interface(dest, copy_names) |
There was a problem hiding this comment.
One could argue whether we want to simplify this now and just having the fallback
copy_to(...) = default_copy_to(...)There was a problem hiding this comment.
Yeah. Let's merge this first and then re-assess all the copy stuff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should decide if we want to do this before merging, but just seeing what the diff would be.
Closes #1341