Add Variable bridges to use runtests without unbridged_variable #2498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
odow
reviewed
May 10, 2024
| _test_structural_identical( | ||
| test, | ||
| model; | ||
| allow_constraint_function_error = allow_outer_constraint_function_error, |
There was a problem hiding this comment.
Suggested change
| allow_constraint_function_error = allow_outer_constraint_function_error, | |
| allow_constraint_function_error, |
This should be sufficient instead of the long line?
There was a problem hiding this comment.
Note the outer_. I only want to allow it when comparing test with model, not with inner
There was a problem hiding this comment.
I'm open to better names ^^
There was a problem hiding this comment.
I, in fact, did not notice the _outer_ 😆
|
Did you try |
|
I did not try, I was just hoping it could serve as a test |
|
The issue is that a bunch of other places may call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some variable bridges don't support
unbridged_variableand that makesruntestsfail when gettingConstraintFunctionor when gettingConstraintSetfor scalar constraints. For example,ZerosBridgedoes not support it so it cannot useruntests.Another example is the SOS cone: jump-dev/SumOfSquares.jl#353 I could support it in the nonweighted version but if it's weighted by arbitrary polynomials, it seems difficult to unbridge. It might be possible but it's not high priority. By using only vector cones in the tests, it turns out that only this small change is enough to pass the tests. This is still testing the inner model completely.
ZerosBridgeby adding a tests without scalar sets