github actions #11
Merged
github actions #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @joaquimg |
blegat
reviewed
Dec 7, 2020
.github/workflows/ci.yml
Outdated
| - macOS-latest | ||
| - windows-latest | ||
| arch: | ||
| - x64 |
There was a problem hiding this comment.
Might be more useful to test for 64 and 32-bit (to catch the Int32 vs Int64 common gotcha's) but only on linux.
There was a problem hiding this comment.
done, I took the one from MOI but added OSX
joaquimg
approved these changes
Dec 7, 2020
|
I think CI is fairly fast on GH-actions. Worst thing we can remove them later |
odow
reviewed
Dec 7, 2020
.github/workflows/ci.yml
Outdated
| arch: x64 | ||
| - version: '1' | ||
| os: macOS-latest | ||
| arch: x64 |
There was a problem hiding this comment.
The rule-of-thumb I went with was:
- Does the package have binary dependencies?
- If yes, test on Linux, Mac, and Window 64-bit, Julia 1 and Julia 1.0
- Also test on linux 32-bit Julia 1.0 for
Int32mistakes - https://github.com/jump-dev/GLPK.jl/blob/master/.github/workflows/ci.yml
- Also test on linux 32-bit Julia 1.0 for
- If no, test on Linux 64-bit, Julia 1 and 1.0, and Linux 32-bit, Julia 1.0
- Optionally test on Window 64-bit, Julia 1.0 to test windows installation
- https://github.com/jump-dev/MathOptInterface.jl/blob/master/.github/workflows/ci.yml
- If yes, test on Linux, Mac, and Window 64-bit, Julia 1 and Julia 1.0
There was a problem hiding this comment.
recommendation followed in last commit
|
Since MOI has binary dependencies, then all depending packages also have
some, or do you mean direct dependencies?
…On Mon, Dec 7, 2020, 19:42 Oscar Dowson ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .github/workflows/ci.yml
<#11 (comment)>
:
> + arch: x64
+ - version: '1'
+ os: ubuntu-latest
+ arch: x64
+ - version: '1.0'
+ os: ubuntu-latest
+ arch: x64
+ - version: '1.0'
+ os: ubuntu-latest
+ arch: x86
+ - version: '1'
+ os: windows-latest
+ arch: x64
+ - version: '1'
+ os: macOS-latest
+ arch: x64
The rule-of-thumb I went with was:
- Does the package have binary dependencies?
- If yes, test on Linux, Mac, and Window 64-bit, Julia 1 and Julia
1.0
- Also test on linux 32-bit Julia 1.0 for Int32 mistakes
-
https://github.com/jump-dev/GLPK.jl/blob/master/.github/workflows/ci.yml
- If no, test on Linux 64-bit, Julia 1 and 1.0, and Linux 32-bit,
Julia 1.0
- Optionally test on Window 64-bit, Julia 1.0 to test windows
installation
-
https://github.com/jump-dev/MathOptInterface.jl/blob/master/.github/workflows/ci.yml
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#11 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB2FDMXNSX6HIWG2VJ2UOFLSTUO2RANCNFSM4UQM3X4A>
.
|
|
Usually just direct. You can assume the down-stream dependencies are well-tested, so you just want to test the first-order integration with binaries (e.g., solvers). |
blegat
approved these changes
Dec 8, 2020
|
ping @joaquimg for merging this one :) |
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding github action for CI and code coverage