Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup turns white #10

Open
june07 opened this issue May 21, 2024 · 7 comments
Open

Popup turns white #10

june07 opened this issue May 21, 2024 · 7 comments

Comments

@june07
Copy link
Owner

june07 commented May 21, 2024

No description provided.

@isomx
Copy link

isomx commented Aug 1, 2024

Yeah same, every time you re-launch the debugger in Node it uses the light theme.

I have tried every combination of options and nothing resolves it, including using the "Override System Theme" UI option in the Chrome extension and ensuring dark theme is selected.

It doesn't matter whether it opens in new window, or tab. Same behavior.

When you open the settings in the inspector window, it shows Dark selected. The only way to switch it to dark is to open settings and alternate between "System Preference" and "Dark" every time it connects, which is far from a viable workaround.

This started for me July 31, 2024, but I see this issue was opened May 21.

NiM Version: 3.9.1
OS: Windows 10 19045.4651
Chrome: 127.0.6533.73

Is there an ETA on the fix?

Anything I can do to help troubleshoot let me know. Big supporter of your work, thanks for your efforts over the years.

@june07
Copy link
Owner Author

june07 commented Aug 2, 2024

I think you might be talking about a different issue. To try and describe this issue a bit better...

When the popup window is open, it will sometimes go completely blank (i.e. white, a blank white background) as in all the elements appear not to be rendered.

What you are describing seems to be an issue with the light/dark theming? If you can provide a screen capture it would help.

@isomx
Copy link

isomx commented Aug 4, 2024

Yeah I realized that after I posted it, sorry about that. But this came up on a Google search and so I was hoping if anybody else had the same issue they'd easily find the open issue so I didn't move it.

Screenshare:
https://www.loom.com/share/78c0f3cf498e4baabc10383189c7e498

Anything else I can do let me know

@june07
Copy link
Owner Author

june07 commented Aug 4, 2024

No worries and thanks for the extra info.

Did some searching and it looks like the issue you are having is due to a bug in Chromium itself. See https://issues.chromium.org/issues/352496164

Apparently a fix has been made:

Verified the fix on latest canary #128.0.6603.0 using Windows 10, Linux Debian and Mac 14.5
Observed that the "DevTools theme" is applied in hosted mode

But you'll need to wait for that version or use Canary for now...

Also, thanks for the prior positive feedback and for being a supporter!

@isomx
Copy link

isomx commented Aug 4, 2024

Wow thanks for the fast reply! Totally makes sense. And yeah will always be a supporter love your work. Thanks again!

@june07
Copy link
Owner Author

june07 commented Aug 5, 2024

@isomx
I actually just pushed another update that should immediately serve as a fix until Google pushes their updates. NiM has had this capability for a while now but there was a small issue I needed to fix with the custom devtools settings.

Anyway, if you use the hosted devtools frontend or build and run it locally yourself you should be able to work around the issue just fine because NiM will use the DevTools code you point it to instead of the built in version that happens to be on whatever version of Chrome (Chromium) you're running.

That should work for you since the light/dark mode seems to be working fine in the latest release. Here's a screenshare of me using both local and hosted versions...

nimCustomDevtools

Let me know how that works out for you...

@isomx
Copy link

isomx commented Aug 5, 2024

Beautiful. Absolutely beautiful. Works perfectly.

This was truly above and beyond, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants