Preview broken by default on linux with powershell

[eruizc-dev]

• I have fzf 0.22.0 or above
• I have read through https://github.com/junegunn/fzf.vim/blob/master/README.md
• I have read through https://github.com/junegunn/fzf/blob/master/README-VIM.md
• I have read through the manual page of fzf (man fzf)
• I have searched through the existing issues

---

Issue

On a fresh install executing :Files causes the preview to display the following error:

The execution of the preview script fails, I assume it's due to the use of single quotes instead of double quotes.

Workaround

I had to override Files command like shown in the fzf.vim readme for it to work

" .vimrc
command! -bang -nargs=? -complete=dir Files
    \ call fzf#vim#files(<q-args>, {'options': ['--layout=reverse', '--info=inline', '--preview', '~/.vim/plugged/fzf.vim/bin/preview.sh {}']}, <bang>0)

Although this is not perfect since all commands that call fzf#vim#with_preview have the exact same error, like :Rg and must be tweaked independently.

---

System info

• OS: Manjaro Linux x86_64
• Desktop: Plasma 5.19.5
• Shell: pwsh PowerShell 7.0.3
• fzf: 0.22.0
• vim: Vi Improved 8.2

[eruizc-dev]

I managed to "fix" this issue by changing the following:

" autoload/fzf/vim.vim line 31
" plugin/fzf.vim line 26
" autoload/fzf/vim/complete.vim line 26
let s:is_win = 1

I guess it's assuming shell based on the OS rather than checking for the shell by itself. I saw some code checking for wsl too.
A proper fix would be to have s:is_win check for cmd/powershell/pwsh rather than win32/win64.

---

Edit:

More specifically, it's the if condition in fzf.vim line 150

  if s:is_win
    let is_wsl_bash = exepath('bash') =~? 'Windows[/\\]system32[/\\]bash.exe$'
    let preview_cmd = 'bash '.(is_wsl_bash
    \ ? substitute(substitute(s:bin.preview, '^\([A-Z]\):', '/mnt/\L\1', ''), '\', '/', 'g')
    \ : escape(s:bin.preview, '\'))
  else
    let preview_cmd = fzf#shellescape(s:bin.preview)
  endif

It assumes that if you're not in windows you're using bash