Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search results overflow into search input field on some terminals when text contains emojis #2697

Open
5 of 10 tasks
ibhagwan opened this issue Dec 28, 2021 · 1 comment
Open
5 of 10 tasks

Comments

@ibhagwan
Copy link

  • I have read through the manual page (man fzf)
  • I have the latest version of fzf
  • I have searched through the existing issues

Info

  • OS
    • Linux
    • Mac OS X
    • Windows
    • Etc.
  • Shell
    • bash
    • zsh
    • fish

Problem / Steps to reproduce

First discovered in: ibhagwan/fzf-lua#275 and reproduced with the latest version of fzf 0.29.0 (dc975e8).

Copying some of the links from this comment by @akrifari for convinience.

Best explained by watching the recordings below, when the text contains emojis while using alacritty/neovim term the search results overflow the input field:

Note that this does work in a kitty terminal (in the shell, not inside neovim):

But given this also happens in alacritty outside the scope of the fzf-lua plugin I'm guessing this is either a terminal issue12 or fzf issue, would love to hear your opinion if this can be mitigrated at the fzf level?

Text with emojis used in the recording
Sit quos enim architecto nobis quas. Sequi dicta aut totam debitis neque ipsa! Est corrupti ea dolorum molestias ea Totam magni magnam maxime optio incidunt? Ipsum sapiente recusandae animi voluptatem
Sit quos enim architecto nobis quas. Sequi dicta aut totam debitis neque ipsa! Est corrupti ea dolorum molestias ea Totam magni magnam maxime optio incidunt? Ipsum sapiente recusandae animi voluptatem
👧🏼 Sit quos enimo architecto nobis quas. Sequi dicta aut totam debitis neque ipsa! Est corrupti ea dolorum molestias ea Totam magni magnam maxime optio incidunt? Ipsum sapiente recusandae animi voluptatem
Sit quos enim architecto nobis quas. Sequi dicta aut totam debitis neque ipsa! Est corrupti ea dolorum molestias ea Totam magni magnam maxime optio incidunt? Ipsum sapiente recusandae animi voluptatem
Sit quos enim architecto nobis quas. Sequi dicta aut totam debitis neque ipsa! Est corrupti ea dolorum molestias ea Totam magni magnam maxime optio incidunt? Ipsum sapiente recusandae animi voluptatem
👧🏼 Sit quos enimo architecto nobis quas. Sequi dicta aut totam debitis neque ipsa! Est corrupti ea dolorum molestias ea Totam magni magnam maxime optio incidunt? Ipsum sapiente recusandae animi voluptatem

Footnotes

  1. https://github.com/neovim/neovim/issues/7151

  2. https://github.com/alacritty/alacritty/issues/3975

@junegunn
Copy link
Owner

junegunn commented Mar 3, 2022

image

Looks like the emoji modifier is not properly handled, taking up extra space which is causing the overflow you see.

echo 👧🏼 should only take up 2 columns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants