addfunc: Modify image uploader #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jungissei
added a commit
that referenced
this pull request
Dec 9, 2020
* refactor: Modify alert style (#69) LGTM * addfunc: Modify image uploader (#71) LGTM * refactor:modify_devise_mail_message/#63 (#73) LGTM * Modify typographical error body email changed #74 * refactor: Modify sign up form #70 (#76) LGTM * addfunc: Add share button #55 (#77) LGTM * Addfunc/modify to ajax/#54 (#79) * addfunc: Split JavaScript files #54 * addfunc: Add function Ajax process to like #54 * addfunc: Add function Ajax process to follow #54 * addfunc: Fix like #54 * addfunc: Fix follow #54 * addfunc: Add function Ajax process to commnent #54 * refactor: Like #54 LGTM * fix: Modify image uploader #72 (#80) LGTM * addfunc: Add functions private post #53 (#84) LGTM * refactor: Refactor gem update nokogiri (#92) LGTM * refactor: Modify lodash (#93) LGTM * refactor: Update websocket-extensions (#94) LGTM * refactor: Update rack (#95) LGTM * refactor: Update puma (#96) LGTM * Bump puma from 4.3.5 to 5.0.4 (#97) Bumps [puma](https://github.com/puma/puma) from 4.3.5 to 5.0.4. - [Release notes](https://github.com/puma/puma/releases) - [Changelog](https://github.com/puma/puma/blob/master/History.md) - [Commits](puma/puma@v4.3.5...v5.0.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Bump rails from 6.0.2.1 to 6.0.3.4 (#98) Bumps [rails](https://github.com/rails/rails) from 6.0.2.1 to 6.0.3.4. - [Release notes](https://github.com/rails/rails/releases) - [Commits](rails/rails@v6.0.2.1...v6.0.3.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Bump dotenv-rails from 2.7.5 to 2.7.6 (#99) Bumps [dotenv-rails](https://github.com/bkeepers/dotenv) from 2.7.5 to 2.7.6. - [Release notes](https://github.com/bkeepers/dotenv/releases) - [Changelog](https://github.com/bkeepers/dotenv/blob/master/Changelog.md) - [Commits](bkeepers/dotenv@v2.7.5...v2.7.6) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Bump bootsnap from 1.4.5 to 1.5.1 (#101) Bumps [bootsnap](https://github.com/Shopify/bootsnap) from 1.4.5 to 1.5.1. - [Release notes](https://github.com/Shopify/bootsnap/releases) - [Changelog](https://github.com/Shopify/bootsnap/blob/master/CHANGELOG.md) - [Commits](Shopify/bootsnap@v1.4.5...v1.5.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Bump listen from 3.1.5 to 3.3.1 (#100) Bumps [listen](https://github.com/guard/listen) from 3.1.5 to 3.3.1. - [Release notes](https://github.com/guard/listen/releases) - [Commits](guard/listen@v3.1.5...v3.3.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * refactor: Update package and yarn * fix: Remove local SSL setting #102 (#105) LGTM * fix: Refactor redirect HOME page after sing-in #103 (#106) LGTM * Create pull_request_template.md * Refactor/improve template UI (#117) * fix: package & yarn * fix: Font Awsome * fix: Ajax process * refactor: Remove reading related Facebook button * refactor: template #104 * refactor: /posts * refactor: /posts/show * refactor: /users * refactor: /posts/ranking * refactor: /psots/search * refactor: /posts when it signout * refactoring Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
jungissei
added a commit
that referenced
this pull request
Dec 9, 2020
* refactor: Modify alert style (#69) LGTM * addfunc: Modify image uploader (#71) LGTM * refactor:modify_devise_mail_message/#63 (#73) LGTM * Modify typographical error body email changed #74 * refactor: Modify sign up form #70 (#76) LGTM * addfunc: Add share button #55 (#77) LGTM * Addfunc/modify to ajax/#54 (#79) * addfunc: Split JavaScript files #54 * addfunc: Add function Ajax process to like #54 * addfunc: Add function Ajax process to follow #54 * addfunc: Fix like #54 * addfunc: Fix follow #54 * addfunc: Add function Ajax process to commnent #54 * refactor: Like #54 LGTM * fix: Modify image uploader #72 (#80) LGTM * addfunc: Add functions private post #53 (#84) LGTM * refactor: Refactor gem update nokogiri (#92) LGTM * refactor: Modify lodash (#93) LGTM * refactor: Update websocket-extensions (#94) LGTM * refactor: Update rack (#95) LGTM * refactor: Update puma (#96) LGTM * Bump puma from 4.3.5 to 5.0.4 (#97) Bumps [puma](https://github.com/puma/puma) from 4.3.5 to 5.0.4. - [Release notes](https://github.com/puma/puma/releases) - [Changelog](https://github.com/puma/puma/blob/master/History.md) - [Commits](puma/puma@v4.3.5...v5.0.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Bump rails from 6.0.2.1 to 6.0.3.4 (#98) Bumps [rails](https://github.com/rails/rails) from 6.0.2.1 to 6.0.3.4. - [Release notes](https://github.com/rails/rails/releases) - [Commits](rails/rails@v6.0.2.1...v6.0.3.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Bump dotenv-rails from 2.7.5 to 2.7.6 (#99) Bumps [dotenv-rails](https://github.com/bkeepers/dotenv) from 2.7.5 to 2.7.6. - [Release notes](https://github.com/bkeepers/dotenv/releases) - [Changelog](https://github.com/bkeepers/dotenv/blob/master/Changelog.md) - [Commits](bkeepers/dotenv@v2.7.5...v2.7.6) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Bump bootsnap from 1.4.5 to 1.5.1 (#101) Bumps [bootsnap](https://github.com/Shopify/bootsnap) from 1.4.5 to 1.5.1. - [Release notes](https://github.com/Shopify/bootsnap/releases) - [Changelog](https://github.com/Shopify/bootsnap/blob/master/CHANGELOG.md) - [Commits](Shopify/bootsnap@v1.4.5...v1.5.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Bump listen from 3.1.5 to 3.3.1 (#100) Bumps [listen](https://github.com/guard/listen) from 3.1.5 to 3.3.1. - [Release notes](https://github.com/guard/listen/releases) - [Commits](guard/listen@v3.1.5...v3.3.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * refactor: Update package and yarn * fix: Remove local SSL setting #102 (#105) LGTM * fix: Refactor redirect HOME page after sing-in #103 (#106) LGTM * Create pull_request_template.md * Refactor/improve template UI (#117) * fix: package & yarn * fix: Font Awsome * fix: Ajax process * refactor: Remove reading related Facebook button * refactor: template #104 * refactor: /posts * refactor: /posts/show * refactor: /users * refactor: /posts/ranking * refactor: /psots/search * refactor: /posts when it signout * refactoring Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
jungissei
added a commit
that referenced
this pull request
Dec 20, 2020
* refactor: Modify alert style (#69) LGTM * addfunc: Modify image uploader (#71) LGTM * refactor:modify_devise_mail_message/#63 (#73) LGTM * Modify typographical error body email changed #74 * refactor: Modify sign up form #70 (#76) LGTM * addfunc: Add share button #55 (#77) LGTM * Addfunc/modify to ajax/#54 (#79) * addfunc: Split JavaScript files #54 * addfunc: Add function Ajax process to like #54 * addfunc: Add function Ajax process to follow #54 * addfunc: Fix like #54 * addfunc: Fix follow #54 * addfunc: Add function Ajax process to commnent #54 * refactor: Like #54 LGTM * fix: Modify image uploader #72 (#80) LGTM * addfunc: Add functions private post #53 (#84) LGTM * refactor: Refactor gem update nokogiri (#92) LGTM * refactor: Modify lodash (#93) LGTM * refactor: Update websocket-extensions (#94) LGTM * refactor: Update rack (#95) LGTM * refactor: Update puma (#96) LGTM * Bump puma from 4.3.5 to 5.0.4 (#97) Bumps [puma](https://github.com/puma/puma) from 4.3.5 to 5.0.4. - [Release notes](https://github.com/puma/puma/releases) - [Changelog](https://github.com/puma/puma/blob/master/History.md) - [Commits](puma/puma@v4.3.5...v5.0.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Bump rails from 6.0.2.1 to 6.0.3.4 (#98) Bumps [rails](https://github.com/rails/rails) from 6.0.2.1 to 6.0.3.4. - [Release notes](https://github.com/rails/rails/releases) - [Commits](rails/rails@v6.0.2.1...v6.0.3.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Bump dotenv-rails from 2.7.5 to 2.7.6 (#99) Bumps [dotenv-rails](https://github.com/bkeepers/dotenv) from 2.7.5 to 2.7.6. - [Release notes](https://github.com/bkeepers/dotenv/releases) - [Changelog](https://github.com/bkeepers/dotenv/blob/master/Changelog.md) - [Commits](bkeepers/dotenv@v2.7.5...v2.7.6) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Bump bootsnap from 1.4.5 to 1.5.1 (#101) Bumps [bootsnap](https://github.com/Shopify/bootsnap) from 1.4.5 to 1.5.1. - [Release notes](https://github.com/Shopify/bootsnap/releases) - [Changelog](https://github.com/Shopify/bootsnap/blob/master/CHANGELOG.md) - [Commits](Shopify/bootsnap@v1.4.5...v1.5.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Bump listen from 3.1.5 to 3.3.1 (#100) Bumps [listen](https://github.com/guard/listen) from 3.1.5 to 3.3.1. - [Release notes](https://github.com/guard/listen/releases) - [Commits](guard/listen@v3.1.5...v3.3.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * refactor: Update package and yarn * fix: Remove local SSL setting #102 (#105) LGTM * fix: Refactor redirect HOME page after sing-in #103 (#106) LGTM * Create pull_request_template.md * Refactor/improve template UI (#117) * fix: package & yarn * fix: Font Awsome * fix: Ajax process * refactor: Remove reading related Facebook button * refactor: template #104 * refactor: /posts * refactor: /posts/show * refactor: /users * refactor: /posts/ranking * refactor: /psots/search * refactor: /posts when it signout * refactoring * fix webpack * fix webpack * fix circleci config * fix webpack * fix webpack * fix webpack * fix webpack * fix webpack Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
jungissei
added a commit
that referenced
this pull request
Dec 20, 2020
* refactor: Modify alert style (#69) LGTM * addfunc: Modify image uploader (#71) LGTM * refactor:modify_devise_mail_message/#63 (#73) LGTM * Modify typographical error body email changed #74 * refactor: Modify sign up form #70 (#76) LGTM * addfunc: Add share button #55 (#77) LGTM * Addfunc/modify to ajax/#54 (#79) * addfunc: Split JavaScript files #54 * addfunc: Add function Ajax process to like #54 * addfunc: Add function Ajax process to follow #54 * addfunc: Fix like #54 * addfunc: Fix follow #54 * addfunc: Add function Ajax process to commnent #54 * refactor: Like #54 LGTM * fix: Modify image uploader #72 (#80) LGTM * addfunc: Add functions private post #53 (#84) LGTM * refactor: Refactor gem update nokogiri (#92) LGTM * refactor: Modify lodash (#93) LGTM * refactor: Update websocket-extensions (#94) LGTM * refactor: Update rack (#95) LGTM * refactor: Update puma (#96) LGTM * Bump puma from 4.3.5 to 5.0.4 (#97) Bumps [puma](https://github.com/puma/puma) from 4.3.5 to 5.0.4. - [Release notes](https://github.com/puma/puma/releases) - [Changelog](https://github.com/puma/puma/blob/master/History.md) - [Commits](puma/puma@v4.3.5...v5.0.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Bump rails from 6.0.2.1 to 6.0.3.4 (#98) Bumps [rails](https://github.com/rails/rails) from 6.0.2.1 to 6.0.3.4. - [Release notes](https://github.com/rails/rails/releases) - [Commits](rails/rails@v6.0.2.1...v6.0.3.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Bump dotenv-rails from 2.7.5 to 2.7.6 (#99) Bumps [dotenv-rails](https://github.com/bkeepers/dotenv) from 2.7.5 to 2.7.6. - [Release notes](https://github.com/bkeepers/dotenv/releases) - [Changelog](https://github.com/bkeepers/dotenv/blob/master/Changelog.md) - [Commits](bkeepers/dotenv@v2.7.5...v2.7.6) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Bump bootsnap from 1.4.5 to 1.5.1 (#101) Bumps [bootsnap](https://github.com/Shopify/bootsnap) from 1.4.5 to 1.5.1. - [Release notes](https://github.com/Shopify/bootsnap/releases) - [Changelog](https://github.com/Shopify/bootsnap/blob/master/CHANGELOG.md) - [Commits](Shopify/bootsnap@v1.4.5...v1.5.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Bump listen from 3.1.5 to 3.3.1 (#100) Bumps [listen](https://github.com/guard/listen) from 3.1.5 to 3.3.1. - [Release notes](https://github.com/guard/listen/releases) - [Commits](guard/listen@v3.1.5...v3.3.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * refactor: Update package and yarn * fix: Remove local SSL setting #102 (#105) LGTM * fix: Refactor redirect HOME page after sing-in #103 (#106) LGTM * Create pull_request_template.md * Refactor/improve template UI (#117) * fix: package & yarn * fix: Font Awsome * fix: Ajax process * refactor: Remove reading related Facebook button * refactor: template #104 * refactor: /posts * refactor: /posts/show * refactor: /users * refactor: /posts/ranking * refactor: /psots/search * refactor: /posts when it signout * refactoring * fix webpack * fix webpack * fix circleci config * fix webpack * fix webpack * fix webpack * fix webpack * fix webpack * fix fog Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #47
概要
修正内容の検証方法
従来のinputタグのみの入力方法から、jQueryを使用して画像プレビューをされる。
Chrome、Firefox、Edge、Safariなどマルチブラウザで動作確認されることを確認すること。
新規投稿ページ・投稿編集ページ、ユーザー情報編集ページで確認すること。
バリデーションさせて動作確認すること。
この修正が正しい理由
Chrome、Firefox、Edge、Safariなどマルチブラウザで動作確認されることを確認した。