Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Modify alert style #69

Merged
merged 1 commit into from
Oct 28, 2020
Merged

refactor: Modify alert style #69

merged 1 commit into from
Oct 28, 2020

Conversation

jungissei
Copy link
Owner

close #62

概要

  • アラートがコンテンツに被って表示されてしまうので、被らないように修正

修正内容の検証方法

下記のコマンド実行後、投稿実行後に表示されるアラートの表示がコンテンツに被っていないか確認

$ docker-compose up -d

この修正が正しい理由

テスト環境にて投稿を行い、コンテンツが被っていないことを確認

@jungissei jungissei self-assigned this Oct 28, 2020
@jungissei jungissei merged commit e23b281 into develop Oct 28, 2020
@jungissei jungissei added the refactoring refactoring label Oct 28, 2020
jungissei added a commit that referenced this pull request Dec 9, 2020
* refactor: Modify alert style (#69)

LGTM

* addfunc: Modify image uploader (#71)

LGTM

* refactor:modify_devise_mail_message/#63 (#73)

LGTM

* Modify typographical error body email changed #74

* refactor: Modify sign up form #70 (#76)

LGTM

* addfunc: Add share button #55 (#77)

LGTM

* Addfunc/modify to ajax/#54 (#79)

* addfunc: Split JavaScript files #54

* addfunc: Add function Ajax process to like #54

* addfunc: Add function Ajax process to follow #54

* addfunc: Fix like #54

* addfunc: Fix follow #54

* addfunc: Add function Ajax process to commnent #54

* refactor: Like #54 

LGTM

* fix: Modify image uploader #72 (#80)

LGTM

* addfunc: Add functions private post #53 (#84)

LGTM

* refactor: Refactor gem update nokogiri (#92)

LGTM

* refactor: Modify lodash (#93)

LGTM

* refactor: Update websocket-extensions (#94)

LGTM

* refactor: Update rack (#95)

LGTM

* refactor: Update puma (#96)

LGTM

* Bump puma from 4.3.5 to 5.0.4 (#97)

Bumps [puma](https://github.com/puma/puma) from 4.3.5 to 5.0.4.
- [Release notes](https://github.com/puma/puma/releases)
- [Changelog](https://github.com/puma/puma/blob/master/History.md)
- [Commits](puma/puma@v4.3.5...v5.0.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* Bump rails from 6.0.2.1 to 6.0.3.4 (#98)

Bumps [rails](https://github.com/rails/rails) from 6.0.2.1 to 6.0.3.4.
- [Release notes](https://github.com/rails/rails/releases)
- [Commits](rails/rails@v6.0.2.1...v6.0.3.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* Bump dotenv-rails from 2.7.5 to 2.7.6 (#99)

Bumps [dotenv-rails](https://github.com/bkeepers/dotenv) from 2.7.5 to 2.7.6.
- [Release notes](https://github.com/bkeepers/dotenv/releases)
- [Changelog](https://github.com/bkeepers/dotenv/blob/master/Changelog.md)
- [Commits](bkeepers/dotenv@v2.7.5...v2.7.6)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* Bump bootsnap from 1.4.5 to 1.5.1 (#101)

Bumps [bootsnap](https://github.com/Shopify/bootsnap) from 1.4.5 to 1.5.1.
- [Release notes](https://github.com/Shopify/bootsnap/releases)
- [Changelog](https://github.com/Shopify/bootsnap/blob/master/CHANGELOG.md)
- [Commits](Shopify/bootsnap@v1.4.5...v1.5.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* Bump listen from 3.1.5 to 3.3.1 (#100)

Bumps [listen](https://github.com/guard/listen) from 3.1.5 to 3.3.1.
- [Release notes](https://github.com/guard/listen/releases)
- [Commits](guard/listen@v3.1.5...v3.3.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* refactor: Update package and yarn

* fix: Remove local SSL setting #102 (#105)

LGTM

* fix: Refactor redirect HOME page after sing-in #103 (#106)

LGTM

* Create pull_request_template.md

* Refactor/improve template UI (#117)

* fix: package & yarn

* fix: Font Awsome

* fix: Ajax process

* refactor: Remove reading related Facebook button

* refactor: template #104

* refactor: /posts

* refactor: /posts/show

* refactor: /users

* refactor: /posts/ranking

* refactor: /psots/search

* refactor: /posts when it signout

* refactoring

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
jungissei added a commit that referenced this pull request Dec 9, 2020
* refactor: Modify alert style (#69)

LGTM

* addfunc: Modify image uploader (#71)

LGTM

* refactor:modify_devise_mail_message/#63 (#73)

LGTM

* Modify typographical error body email changed #74

* refactor: Modify sign up form #70 (#76)

LGTM

* addfunc: Add share button #55 (#77)

LGTM

* Addfunc/modify to ajax/#54 (#79)

* addfunc: Split JavaScript files #54

* addfunc: Add function Ajax process to like #54

* addfunc: Add function Ajax process to follow #54

* addfunc: Fix like #54

* addfunc: Fix follow #54

* addfunc: Add function Ajax process to commnent #54

* refactor: Like #54 

LGTM

* fix: Modify image uploader #72 (#80)

LGTM

* addfunc: Add functions private post #53 (#84)

LGTM

* refactor: Refactor gem update nokogiri (#92)

LGTM

* refactor: Modify lodash (#93)

LGTM

* refactor: Update websocket-extensions (#94)

LGTM

* refactor: Update rack (#95)

LGTM

* refactor: Update puma (#96)

LGTM

* Bump puma from 4.3.5 to 5.0.4 (#97)

Bumps [puma](https://github.com/puma/puma) from 4.3.5 to 5.0.4.
- [Release notes](https://github.com/puma/puma/releases)
- [Changelog](https://github.com/puma/puma/blob/master/History.md)
- [Commits](puma/puma@v4.3.5...v5.0.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* Bump rails from 6.0.2.1 to 6.0.3.4 (#98)

Bumps [rails](https://github.com/rails/rails) from 6.0.2.1 to 6.0.3.4.
- [Release notes](https://github.com/rails/rails/releases)
- [Commits](rails/rails@v6.0.2.1...v6.0.3.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* Bump dotenv-rails from 2.7.5 to 2.7.6 (#99)

Bumps [dotenv-rails](https://github.com/bkeepers/dotenv) from 2.7.5 to 2.7.6.
- [Release notes](https://github.com/bkeepers/dotenv/releases)
- [Changelog](https://github.com/bkeepers/dotenv/blob/master/Changelog.md)
- [Commits](bkeepers/dotenv@v2.7.5...v2.7.6)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* Bump bootsnap from 1.4.5 to 1.5.1 (#101)

Bumps [bootsnap](https://github.com/Shopify/bootsnap) from 1.4.5 to 1.5.1.
- [Release notes](https://github.com/Shopify/bootsnap/releases)
- [Changelog](https://github.com/Shopify/bootsnap/blob/master/CHANGELOG.md)
- [Commits](Shopify/bootsnap@v1.4.5...v1.5.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* Bump listen from 3.1.5 to 3.3.1 (#100)

Bumps [listen](https://github.com/guard/listen) from 3.1.5 to 3.3.1.
- [Release notes](https://github.com/guard/listen/releases)
- [Commits](guard/listen@v3.1.5...v3.3.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* refactor: Update package and yarn

* fix: Remove local SSL setting #102 (#105)

LGTM

* fix: Refactor redirect HOME page after sing-in #103 (#106)

LGTM

* Create pull_request_template.md

* Refactor/improve template UI (#117)

* fix: package & yarn

* fix: Font Awsome

* fix: Ajax process

* refactor: Remove reading related Facebook button

* refactor: template #104

* refactor: /posts

* refactor: /posts/show

* refactor: /users

* refactor: /posts/ranking

* refactor: /psots/search

* refactor: /posts when it signout

* refactoring

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
jungissei added a commit that referenced this pull request Dec 20, 2020
* refactor: Modify alert style (#69)

LGTM

* addfunc: Modify image uploader (#71)

LGTM

* refactor:modify_devise_mail_message/#63 (#73)

LGTM

* Modify typographical error body email changed #74

* refactor: Modify sign up form #70 (#76)

LGTM

* addfunc: Add share button #55 (#77)

LGTM

* Addfunc/modify to ajax/#54 (#79)

* addfunc: Split JavaScript files #54

* addfunc: Add function Ajax process to like #54

* addfunc: Add function Ajax process to follow #54

* addfunc: Fix like #54

* addfunc: Fix follow #54

* addfunc: Add function Ajax process to commnent #54

* refactor: Like #54 

LGTM

* fix: Modify image uploader #72 (#80)

LGTM

* addfunc: Add functions private post #53 (#84)

LGTM

* refactor: Refactor gem update nokogiri (#92)

LGTM

* refactor: Modify lodash (#93)

LGTM

* refactor: Update websocket-extensions (#94)

LGTM

* refactor: Update rack (#95)

LGTM

* refactor: Update puma (#96)

LGTM

* Bump puma from 4.3.5 to 5.0.4 (#97)

Bumps [puma](https://github.com/puma/puma) from 4.3.5 to 5.0.4.
- [Release notes](https://github.com/puma/puma/releases)
- [Changelog](https://github.com/puma/puma/blob/master/History.md)
- [Commits](puma/puma@v4.3.5...v5.0.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* Bump rails from 6.0.2.1 to 6.0.3.4 (#98)

Bumps [rails](https://github.com/rails/rails) from 6.0.2.1 to 6.0.3.4.
- [Release notes](https://github.com/rails/rails/releases)
- [Commits](rails/rails@v6.0.2.1...v6.0.3.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* Bump dotenv-rails from 2.7.5 to 2.7.6 (#99)

Bumps [dotenv-rails](https://github.com/bkeepers/dotenv) from 2.7.5 to 2.7.6.
- [Release notes](https://github.com/bkeepers/dotenv/releases)
- [Changelog](https://github.com/bkeepers/dotenv/blob/master/Changelog.md)
- [Commits](bkeepers/dotenv@v2.7.5...v2.7.6)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* Bump bootsnap from 1.4.5 to 1.5.1 (#101)

Bumps [bootsnap](https://github.com/Shopify/bootsnap) from 1.4.5 to 1.5.1.
- [Release notes](https://github.com/Shopify/bootsnap/releases)
- [Changelog](https://github.com/Shopify/bootsnap/blob/master/CHANGELOG.md)
- [Commits](Shopify/bootsnap@v1.4.5...v1.5.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* Bump listen from 3.1.5 to 3.3.1 (#100)

Bumps [listen](https://github.com/guard/listen) from 3.1.5 to 3.3.1.
- [Release notes](https://github.com/guard/listen/releases)
- [Commits](guard/listen@v3.1.5...v3.3.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* refactor: Update package and yarn

* fix: Remove local SSL setting #102 (#105)

LGTM

* fix: Refactor redirect HOME page after sing-in #103 (#106)

LGTM

* Create pull_request_template.md

* Refactor/improve template UI (#117)

* fix: package & yarn

* fix: Font Awsome

* fix: Ajax process

* refactor: Remove reading related Facebook button

* refactor: template #104

* refactor: /posts

* refactor: /posts/show

* refactor: /users

* refactor: /posts/ranking

* refactor: /psots/search

* refactor: /posts when it signout

* refactoring

* fix webpack

* fix webpack

* fix circleci config

* fix webpack

* fix webpack

* fix webpack

* fix webpack

* fix webpack

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
jungissei added a commit that referenced this pull request Dec 20, 2020
* refactor: Modify alert style (#69)

LGTM

* addfunc: Modify image uploader (#71)

LGTM

* refactor:modify_devise_mail_message/#63 (#73)

LGTM

* Modify typographical error body email changed #74

* refactor: Modify sign up form #70 (#76)

LGTM

* addfunc: Add share button #55 (#77)

LGTM

* Addfunc/modify to ajax/#54 (#79)

* addfunc: Split JavaScript files #54

* addfunc: Add function Ajax process to like #54

* addfunc: Add function Ajax process to follow #54

* addfunc: Fix like #54

* addfunc: Fix follow #54

* addfunc: Add function Ajax process to commnent #54

* refactor: Like #54 

LGTM

* fix: Modify image uploader #72 (#80)

LGTM

* addfunc: Add functions private post #53 (#84)

LGTM

* refactor: Refactor gem update nokogiri (#92)

LGTM

* refactor: Modify lodash (#93)

LGTM

* refactor: Update websocket-extensions (#94)

LGTM

* refactor: Update rack (#95)

LGTM

* refactor: Update puma (#96)

LGTM

* Bump puma from 4.3.5 to 5.0.4 (#97)

Bumps [puma](https://github.com/puma/puma) from 4.3.5 to 5.0.4.
- [Release notes](https://github.com/puma/puma/releases)
- [Changelog](https://github.com/puma/puma/blob/master/History.md)
- [Commits](puma/puma@v4.3.5...v5.0.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* Bump rails from 6.0.2.1 to 6.0.3.4 (#98)

Bumps [rails](https://github.com/rails/rails) from 6.0.2.1 to 6.0.3.4.
- [Release notes](https://github.com/rails/rails/releases)
- [Commits](rails/rails@v6.0.2.1...v6.0.3.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* Bump dotenv-rails from 2.7.5 to 2.7.6 (#99)

Bumps [dotenv-rails](https://github.com/bkeepers/dotenv) from 2.7.5 to 2.7.6.
- [Release notes](https://github.com/bkeepers/dotenv/releases)
- [Changelog](https://github.com/bkeepers/dotenv/blob/master/Changelog.md)
- [Commits](bkeepers/dotenv@v2.7.5...v2.7.6)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* Bump bootsnap from 1.4.5 to 1.5.1 (#101)

Bumps [bootsnap](https://github.com/Shopify/bootsnap) from 1.4.5 to 1.5.1.
- [Release notes](https://github.com/Shopify/bootsnap/releases)
- [Changelog](https://github.com/Shopify/bootsnap/blob/master/CHANGELOG.md)
- [Commits](Shopify/bootsnap@v1.4.5...v1.5.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* Bump listen from 3.1.5 to 3.3.1 (#100)

Bumps [listen](https://github.com/guard/listen) from 3.1.5 to 3.3.1.
- [Release notes](https://github.com/guard/listen/releases)
- [Commits](guard/listen@v3.1.5...v3.3.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* refactor: Update package and yarn

* fix: Remove local SSL setting #102 (#105)

LGTM

* fix: Refactor redirect HOME page after sing-in #103 (#106)

LGTM

* Create pull_request_template.md

* Refactor/improve template UI (#117)

* fix: package & yarn

* fix: Font Awsome

* fix: Ajax process

* refactor: Remove reading related Facebook button

* refactor: template #104

* refactor: /posts

* refactor: /posts/show

* refactor: /users

* refactor: /posts/ranking

* refactor: /psots/search

* refactor: /posts when it signout

* refactoring

* fix webpack

* fix webpack

* fix circleci config

* fix webpack

* fix webpack

* fix webpack

* fix webpack

* fix webpack

* fix fog

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flashメッセージがコンテンツと被ってしまっている問題
1 participant