Use Iterable for the parameters of Parameterized (fixes gh-104). #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method annotated with @parameterized returns an Iterable<Object[]> (was List<Object[]> before). The test fails with a meaningful exception otherwise.
|
This does have a subtle behavior change: before this change, the List<Object[]> of parameters can lazily return members (for example, reading them from disk only when asked for by the particular TestClassRunnerForParameters is ready to run). After this change, all members of the parameters Iterable will be computed up front. I'm not sure if anyone ever used the lazy-loading option: if you understand what I'm getting at, would you have a chance to ping the list at junit@yahoogroups.com and see if everyone's OK with the change? Thanks, David |
|
There's no response from the mailing list. Maybe we could merge this pull request. |
dsaff
added a commit
that referenced
this pull request
Dec 31, 2011
Use Iterable for the parameters of Parameterized (fixes gh-104).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method annotated with @parameterized returns an Iterable<Object[]>
(was List<Object[]> before). The test fails with a meaningful exception
otherwise.