Parameterized runner should name tests better than sequential numbers #44

anshnd · 2009-11-16T18:55:07Z

Right now the test names are named sequentially 0,1, etc in Parameterized:

@OverRide
protected String getName() {
return String.format("[%s]", fParameterSetNumber);
}

@OverRide
protected String testName(final Method method) {
return String.format("%s[%s]", method.getName(), fParameterSetNumber);
}

It would help if the data themselves were to be used in determining the name. Proposed alternatives for name (which has to be determinited statically before Test is instantiated):

call toString on first parameter
call the a newly added names attribute to Parameters annotation (with default empty names for compatibility)
public String[] names() default {};
call a public, static (!) method annotated by newly-defined @testname
and accepting the same arguments as the constructor

I can provide (again) a patch. This issue was tracked as http://sourceforge.net/tracker/?func=detail&atid=365278&aid=1742040&group_id=15278 and https://sourceforge.net/tracker/?func=detail&atid=365278&aid=1630834&group_id=15278
I can submit a patch if needed

JThoennes · 2009-12-08T14:43:08Z

How about this issue? The suggestions are good, when will you implement it / incorporate the patch?

Thanks, Jörg

JThoennes · 2009-12-08T14:49:01Z

See also issue 24 which talks about the same topic, but was entered by dsaff.

jjunit2010 · 2010-01-24T23:19:52Z

Any more news on when this fix might be implemented?

reccles · 2010-02-05T14:49:33Z

There appears to be some demand for this simple feature outside as well: http://stackoverflow.com/questions/650894/change-test-name-of-parameterized-tests

Yishai · 2010-02-05T15:47:57Z

As an additional (simpler) suggestion, how about just changing
@OverRide protected String testName(final FrameworkMethod method) {
return String.format("%s%s", method.getName(),
Arrays.toString(fParameterList.get(fParameterSetNumber)));
}

dbt · 2010-02-19T22:16:38Z

From my deployment experience (I forked Parameterized internally to my project and extended it with similar functionality), using toString or non-static testName() functions were suboptimal, and using a fixed portion of the parameters list (either the first parameter or all of them) was also not useful. My preferred solution was to support an annotated static method that took the same arguments as the constructor and returned a string, and fall back to the test number if that didn't work.

I'm happy to get the (fairly trivial) patch open sourced if that would help solve this problem.

Thanks,
-dave

ralfebert · 2010-07-26T14:57:50Z

See http://github.com/ralfebert/junit/commit/d5fedb0

JThoennes · 2010-09-28T14:12:13Z

Could this patch merged into the next JUnit release, please?

And when will the next release happen?

davidkarlsen · 2010-10-13T23:27:56Z

+1

kaipe · 2011-01-16T23:03:23Z

I have released a framework that offers a solution to this problem:
http://callbackparams.org The test-class runner that will probably solve most cases where this problem arises is ...
http://callbackparams.org/project/api-javadoc/org/callbackparams/junit4/EnumRunner.html ... and for more complex cases the rest of the framework has a lot to offer.

The key feature in regard to this issue is that tests are named by the overridden method java.lang.Object#toString(), which for enum-constants happen to return the name of the constant. If the enum-constant name won't do it is of course still possible to override java.lang.Object#toString() explicitly for those constants that need more verbose test-names.

Anyhow, I think that a solution that does not rely on the toString()-method is simply not very elegant.

alexeyOnGitHub · 2011-06-07T06:30:12Z

the source code posted here worked perfectly
http://stackoverflow.com/questions/650894/change-test-name-of-parameterized-tests

here are the direct links to the source code:

http://code.google.com/p/migen/source/browse/trunk/java/src/uk/ac/lkl/common/util/testing/LabelledParameterized.java?r=3789

http://code.google.com/p/migen/source/browse/trunk/java/src/uk/ac/lkl/common/util/restlet/test/builder/ServerBuilderTest.java?r=3789

mmakowski · 2011-07-08T14:52:30Z

+1

soehalim · 2011-09-07T19:19:21Z

+1

elygre · 2011-09-20T15:57:19Z

+1

binkley · 2011-10-12T22:02:51Z

+1

davidkarlsen · 2011-10-13T17:09:08Z

Cmon! Why can't you apply this Kent? You even have ready patches and the issue is ancient. Isn't good naming part of cleancode and TDD practices - or do we simply have to dump junit for testng?

sivaram-psg · 2011-10-13T17:31:49Z

+1

joelmheim · 2011-10-20T10:40:42Z

+1

stefanbirkner · 2011-10-20T13:46:13Z

I like Dave's idea of a label method. It may look like

@Label
public String labelForParameters(Object... parameters) {
  ...
}

Hopefully there's time today or tomorrow evening to implement this.

jonfreedman · 2011-10-22T10:32:21Z

+1

stefanbirkner · 2011-10-24T08:56:00Z

I'm just waiting for pull request #348

bsbodden · 2011-12-14T19:23:29Z

+1

RaviH · 2011-12-20T23:02:58Z

+1 (guessing that's the way to vote it up?)

Tibor17 · 2011-12-21T22:21:37Z

+1

Jeanguitoune · 2012-01-03T07:20:39Z

+1

yurodivuie · 2012-01-17T05:13:38Z

+1. We've started keeping our own version of Parameterized to fix this problem, but it would be great to have this supported from the source.

slongoni · 2012-01-25T17:18:03Z

+1

sharfah · 2012-01-26T09:04:15Z

+1

cwhite102 · 2012-02-07T02:34:23Z

+1

veger · 2012-02-20T12:18:50Z

+1

java-artisan · 2012-02-21T15:39:50Z

+1

lbuchy · 2012-02-22T06:47:37Z

+1

mrmanc · 2012-02-29T16:28:25Z

+1

ghost · 2012-03-01T19:30:26Z

+1

mariusx · 2012-03-02T10:34:14Z

+1

@parameters

. In order that you can easily identify individual test, you may provide a name for the Parameters annotation. @parameters(name="my test") This name is allowed to contain placeholders, which are replaced at runtime. The placeholders are * {index} - the current parameter index * {0} - the first parameter * {1} - the second parameter * ... - the other parameters If you don't use the name parameter, then the current parameter index is used as name. Example: When you use @parameters(name="fib({0})={1}") with the Fibonacci example, then you get test names like "fib(3)=2". This feature is based on the work of Dimitar Dimitrov (pull request junit-team#145). Thank you.

jpfielding · 2012-03-12T13:47:54Z

+2

z3jiang · 2012-03-26T19:38:33Z

+1

avernet · 2012-03-29T23:52:30Z

+1

@parameters

. In order that you can easily identify individual test, you may provide a name for the Parameters annotation. @parameters(name="my test") This name is allowed to contain placeholders, which are replaced at runtime. The placeholders are * {index} - the current parameter index * {0} - the first parameter * {1} - the second parameter * ... - the other parameters If you don't use the name parameter, then the current parameter index is used as name. Example: When you use @parameters(name="fib({0})={1}") with the Fibonacci example, then you get test names like "fib(3)=2". This feature is based on the work of Dimitar Dimitrov (pull request junit-team#145). Thank you.

Add names for parameterized tests. Fixes #24 and #44.

guyburton · 2012-04-12T11:58:12Z

+1 we have used a fork of Parameterized to implement this feature. We have also made the TestClassRunnerForParameters protected, and it is created by a protected method to allow extension of Parameterized within another implementation of Suite.

stefanbirkner · 2012-04-12T13:24:12Z

The feature is implemented. See #393.

@dsaff Could you please close the issue.

dsaff · 2012-04-12T13:48:39Z

Done.

java-artisan · 2012-04-23T15:34:04Z

Many thanks indeed ! :-)

ddimtirov mentioned this issue Nov 3, 2011

Provide description patterns for Parameterized tests (addressing issues #24, #44 and #135) #145

Closed

dsaff added a commit that referenced this issue Apr 9, 2012

Merge pull request #393 from stefanbirkner/Parameterized

3a5c9f2

Add names for parameterized tests. Fixes #24 and #44.

dsaff closed this as completed Apr 12, 2012

dsaff mentioned this issue Jun 5, 2013

Show parameter values for parametrized tests #223

Closed

stefanbirkner added the parameterized label Feb 12, 2014

Parameterized runner should name tests better than sequential numbers #44

Parameterized runner should name tests better than sequential numbers #44

Comments

anshnd commented Nov 16, 2009

JThoennes commented Dec 8, 2009

JThoennes commented Dec 8, 2009

jjunit2010 commented Jan 24, 2010

reccles commented Feb 5, 2010

Yishai commented Feb 5, 2010

dbt commented Feb 19, 2010

ralfebert commented Jul 26, 2010

JThoennes commented Sep 28, 2010

davidkarlsen commented Oct 13, 2010

kaipe commented Jan 16, 2011

alexeyOnGitHub commented Jun 7, 2011

mmakowski commented Jul 8, 2011

soehalim commented Sep 7, 2011

elygre commented Sep 20, 2011

binkley commented Oct 12, 2011

davidkarlsen commented Oct 13, 2011

sivaram-psg commented Oct 13, 2011

joelmheim commented Oct 20, 2011

stefanbirkner commented Oct 20, 2011

jonfreedman commented Oct 22, 2011

stefanbirkner commented Oct 24, 2011

bsbodden commented Dec 14, 2011

RaviH commented Dec 20, 2011

Tibor17 commented Dec 21, 2011

Jeanguitoune commented Jan 3, 2012

yurodivuie commented Jan 17, 2012

slongoni commented Jan 25, 2012

sharfah commented Jan 26, 2012

cwhite102 commented Feb 7, 2012

veger commented Feb 20, 2012

java-artisan commented Feb 21, 2012

lbuchy commented Feb 22, 2012

mrmanc commented Feb 29, 2012

ghost commented Mar 1, 2012

mariusx commented Mar 2, 2012

jpfielding commented Mar 12, 2012

z3jiang commented Mar 26, 2012

avernet commented Mar 29, 2012

guyburton commented Apr 12, 2012

stefanbirkner commented Apr 12, 2012

dsaff commented Apr 12, 2012

java-artisan commented Apr 23, 2012