Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a definition of "container" in the User Guide #2205

Closed
vinogradoff opened this issue Mar 3, 2020 · 7 comments
Closed

Provide a definition of "container" in the User Guide #2205

vinogradoff opened this issue Mar 3, 2020 · 7 comments

Comments

@vinogradoff
Copy link

vinogradoff commented Mar 3, 2020

The word container is used more than 50 times in the current Guide https://junit.org/junit5/docs/current/user-guide/

This term wasn't used in JUnit4 and is new to many JUnit users. In the development industry we have just too many different containers to leave this to "common sense" understanding.

Please just add the definition of JUnit5 "container" in the User Guide.

@sormuras
Copy link
Member

sormuras commented Mar 3, 2020

Agreed, we should define the word in the User Guide.

Related question on SO (by @vinogradoff, I guess): https://stackoverflow.com/questions/60507366/what-is-a-container-in-junit-5

@sormuras sormuras added this to the 5.7 Backlog milestone Mar 3, 2020
@stale
Copy link

stale bot commented May 13, 2021

This issue has been automatically marked as stale because it has not had recent activity. Given the limited bandwidth of the team, it will be automatically closed if no further activity occurs. Thank you for your contribution.

@stale stale bot added the status: stale label May 13, 2021
@jbduncan
Copy link
Contributor

This sounds like this would be useful to document still.

@stale stale bot removed the status: stale label May 13, 2021
@marcphilipp marcphilipp removed this from the 5.8 Backlog milestone Jun 19, 2021
@Nogtif
Copy link

Nogtif commented Nov 30, 2021

Hello, I am interested in contributing to this issue.
His it still avaible ? :)

@sbrannen
Copy link
Member

sbrannen commented Dec 1, 2021

@Sowtch, yes this issue is still open.

@Nogtif
Copy link

Nogtif commented Dec 1, 2021

Ok thank you for your answer, I'll take care of it then.

@CorentinDelrue
Copy link

I hope this little doc update done with @Sowtch will be satisfying :)

@sbrannen sbrannen changed the title User Guide: The definition of "container" in JUnit5 context should be written down. Provide a definition of "container" in the User Guide Mar 19, 2022
@marcphilipp marcphilipp added this to the 5.9 M1 milestone Apr 11, 2022
@marcphilipp marcphilipp linked a pull request Apr 11, 2022 that will close this issue
7 tasks
@marcphilipp marcphilipp modified the milestones: 5.9 M1, 5.9 M2 May 13, 2022
@sbrannen sbrannen assigned marcphilipp and unassigned Nogtif Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants