Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Guide should not state that junit-platform-console-standalone contains junit-platform-suite aggregator #3658

Closed
sbrannen opened this issue Jan 23, 2024 · 0 comments

Comments

@sbrannen
Copy link
Member

sbrannen commented Jan 23, 2024

Overview

The User Guide currently states that the junit-platform-console-standalone JAR contains the contents of the junit-platform-suite, junit-platform-suite-api, junit-platform-suite-commons, and junit-platform-suite-engine.

However there is no need for it to mention the junit-platform-suite aggregator.

Analysis

Paraphrasing the analysis provided by @marcphilipp in a team discussion...

The build task takes into account all dependencies declared on junit-platform-console-standalone:

dependencies {
shadowed(projects.junitPlatformReporting)
shadowed(projects.junitPlatformConsole)
shadowed(projects.junitPlatformSuite)
shadowed(projects.junitJupiterEngine)
shadowed(projects.junitJupiterParams)
shadowed(projects.junitVintageEngine)
shadowed(libs.apiguardian) {
because("downstream projects need it to avoid compiler warnings")
}
}

If we replace projects.junitPlatformSuite with the individual projects, it might automatically correct itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants