Don't close archive when FileObject streams close #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you be able to provide a sample code or a failing test of the current behaviour? Also, your PR doesn't pass CheckStyle. |
Currently, if you open an input stream for a file and then close it, the entire archive is closed, but VFS will keep trying to use it, and any future input streams you open will just close immediately (because junrar silently swallows an NPE in the pipe writer thread). The built-in providers have this same notifyAllStreamsClosed() method commented out. It does not seem like correct behavior.
pclewis
force-pushed
the
dont-close-archive-when-file-closed
branch
from
4ba6154
to
943c4ca
Compare
Codecov Report
@@ Coverage Diff @@
## master #6 +/- ##
============================================
+ Coverage 60.76% 61.71% +0.94%
Complexity 28 28
============================================
Files 6 6
Lines 130 128 -2
Branches 8 8
============================================
Hits 79 79
+ Misses 46 44 -2
Partials 5 5
Continue to review full report at Codecov.
|
|
The change to the existing test demonstrates the issue. There are no exceptions, but the second input stream is empty: |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 31, 2020
## [1.1.1](v1.1.0...v1.1.1) (2020-12-31) ### Bug Fixes * don't close archive when FileObject streams close ([#6](#6)) ([080826c](080826c))
|
🎉 This PR is included in version 1.1.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you open an input stream for a file and then close it,
the entire archive is closed, but VFS will keep trying to use it, and
any future input streams you open will just close immediately (because
junrar silently swallows an NPE in the pipe writer thread).
The built-in providers have this same notifyAllStreamsClosed() method
commented out. It does not seem like correct behavior.