Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update detail view for job definition #92

Merged
merged 43 commits into from
Oct 7, 2022

Conversation

andrii-i
Copy link
Collaborator

@andrii-i andrii-i commented Oct 4, 2022

  • Introduce a top level field into the job detail model that determines if it is a Job or Job Definition. This along with the id should be used to issue the describe call and render the appropriate detail view.
  • Change the breadcrumb text and link to reflect if it is a Job or Job Definition.

If it is a Job Definition:

  • Render the schedule in human readable form.
  • Change actions to be Delete and Pause.

Closes #86

definition_detail_early_preview.mov

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2022

Binder 👈 Launch a Binder on branch andrii-i/jupyter-scheduler/job-detail

@andrii-i andrii-i changed the title Update detail for for job schedule #86 Update detail for for job schedule Oct 4, 2022
@andrii-i andrii-i modified the milestone: Job scheduling Oct 4, 2022
@andrii-i andrii-i changed the title Update detail for for job schedule Update detail for job schedule Oct 5, 2022
@3coins
Copy link
Collaborator

3coins commented Oct 5, 2022

@andrii-i
Please take a look at the recent updates in the DescribeJobDefinition model, there is no more job_ids property. This has to be loaded from the /jobs list API by passing the job_definition_id.

@3coins 3coins changed the title Update detail for job schedule Update detail for job definition Oct 5, 2022
@3coins 3coins changed the title Update detail for job definition Update detail view for job definition Oct 5, 2022
@andrii-i andrii-i force-pushed the job-detail branch 4 times, most recently from ac20752 to c2be337 Compare October 6, 2022 17:05
@dlqqq dlqqq force-pushed the job-detail branch 2 times, most recently from 45bbde6 to a842625 Compare October 7, 2022 00:13
@dlqqq
Copy link
Collaborator

dlqqq commented Oct 7, 2022

Helped Andrii rebase and added a few commits to make the pause/resume buttons functional.

@3coins Need your review on this commit. The API did not allow me to update active attribute on a job definition. Wanted to make sure I'm not making a regression. 4b00854

@dlqqq dlqqq requested a review from 3coins October 7, 2022 01:25
@andrii-i andrii-i marked this pull request as ready for review October 7, 2022 01:31
src/model.ts Outdated Show resolved Hide resolved
@andrii-i andrii-i mentioned this pull request Oct 7, 2022
@dlqqq dlqqq merged commit 2598838 into jupyter-server:main Oct 7, 2022
@andrii-i andrii-i deleted the job-detail branch October 7, 2022 20:50
@andrii-i andrii-i restored the job-detail branch October 7, 2022 21:15
@andrii-i andrii-i deleted the job-detail branch October 7, 2022 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update detail for for job schedule
4 participants