Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest release is breaking custom ContentManager #1366

Closed
fcollonval opened this issue Nov 22, 2023 · 4 comments · Fixed by #1367
Closed

Latest release is breaking custom ContentManager #1366

fcollonval opened this issue Nov 22, 2023 · 4 comments · Fixed by #1367
Assignees
Labels

Comments

@fcollonval
Copy link
Member

Description

#1363 changed the ContentManager API in a breaking manner; this can be seen in mwouts/jupytext#1165
But I hit it too on private code.

Reproduce

Install jupytext

Expected behavior

The content manager get should be called without md5 if it does not support it.

Context

  • Jupyter Server version: 2.11.0
Command Line Output
 TypeError: build_jupytext_contents_manager_class..JupytextContentsManager.get() got an unexpected keyword argument 'md5'
@fcollonval fcollonval added the bug label Nov 22, 2023
@fcollonval fcollonval self-assigned this Nov 22, 2023
@marr75
Copy link

marr75 commented Nov 22, 2023

This also impacts the ploomber project.

It's disappointing that a breaking change was introduced without a major version or that an interface change that was non-breaking was not devised.

@blink1073
Copy link
Contributor

I yanked 2.11.0. Please let's keep the tone civil, we're all volunteers doing our best, the breaking API change was unintentional.

@Wh1isper
Copy link
Contributor

Sorry for the breaking changes to the API. I have created #1367 to fix this.

@m-rossi
Copy link
Contributor

m-rossi commented Nov 23, 2023

I also created a PR to mark the conda-forge-package as broken: conda-forge/admin-requests#864

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants