Handle open_browser trait in ServerApp and ExtensionApp differently #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zsailer
approved these changes
Jan 6, 2021
|
👍 thanks, @afshin |
jasongrout
added a commit
to jasongrout/jupyterlab
that referenced
this pull request
Jan 8, 2021
This follows on changes to Jupyter Server and ExtensionApp which moves open_browser to the ExtensionApp config. See jupyter-server/jupyter_server#375 Fixes jupyterlab#9579
hMED22
pushed a commit
to hMED22/jupyter_server
that referenced
this pull request
Jan 23, 2023
Handle open_browser trait in ServerApp and ExtensionApp differently
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a configurable
open_browsertrait toExtensionApps, and refactors theServerAppto handle browser-opening properly when another app, e.g. anExtensionApp, starts the server.This also adds a property,
starter_app, toServerAppthat enables theServerAppto know when an extension started the app (versus starting the server directly).This will help address this issue seen in JupyterLab: jupyterlab/jupyterlab_server#145
A follow up PR in JupyterLab is needed to use this new trait.