Add deprecation warnings for API changes #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…here needed. I left in a backwards-compatible shim for giving the name argument to the LegendControl.
|
In starting to do the release, and looking over the changelog one last time, I felt there needed to be more explanation and consistency in our docs around #979. |
|
Also I realized #982 wasn't documented in the changelog, so I did that too. |
|
I created an 0.17.0 milestone to have the issues I think should be in the release. If those two issues pass review and are merged, I am happy to do the 0.17.0 release: |
|
@HaudinFlorence, you could also review this. Thanks again for the changes cleaning the api up! |
|
This also adds a top-level Releases category for the docs to give visibility to the changelog (and list of breaking changes, etc.) |
martinRenou
reviewed
Jun 24, 2022
This also adds back in some API changes as deprecated, and switches a few more from PendingDeprecationWarnings to DeprecationWarnings.
jasongrout
changed the title
jasongrout
commented
Jun 25, 2022
HaudinFlorence
pushed a commit
to HaudinFlorence/ipyleaflet
that referenced
this pull request
Jun 30, 2022
Add deprecation warnings for API changes
HaudinFlorence
pushed a commit
to HaudinFlorence/ipyleaflet
that referenced
this pull request
Jun 30, 2022
Add deprecation warnings for API changes
HaudinFlorence
pushed a commit
to HaudinFlorence/ipyleaflet
that referenced
this pull request
Jun 30, 2022
Add deprecation warnings for API changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup of #979, correcting our LegendControl docs where needed.
I left in a backwards-compatible shim for giving the name argument to the LegendControl, since that is likely the most common thing people would have to change.