Remove get and set decorators in LegendControl in leaflet.py. #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! This is a breaking change and we should make the next release a |
jasongrout
added a commit
to jasongrout/ipyleaflet
that referenced
this pull request
Jun 23, 2022
…here needed. I left in a backwards-compatible shim for giving the name argument to the LegendControl.
|
I added these back in as deprecated things in #1005 for backwards compatibility |
HaudinFlorence
deleted the
Remove_getter_and_setter_decorators_in_LegendControl
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove get and set decorators in LegendControl in leaflet.py.