Move Python packages to the python folder
#3301
Conversation
|
|
jtpio
changed the title
py folder
|
All checks are green, and the preview seems to be building fine on ReadTheDocs. |
jtpio
force-pushed
the
python-monorepo
branch
from
8b87c8e
to
f9f5061
Compare
jtpio
changed the title
py folderpython folder
|
@jtpio, I fixed a few more places where we needed to update the paths. Do my changes look good to you? In particular, does the dev-install.sh script work for you to install dev versions of the packages? |
|
Ah thanks @jasongrout for catching this, changes look good. It's interesting that we were not calling the |
jasongrout
force-pushed
the
python-monorepo
branch
from
d233934
to
2b2b52f
Compare
It was important to change the workspaces in package.json to point to the new locations so that yarn/lerna could find the new locations. I also updated the dev-install.sh to be consistent with how it was installing each python package.
jasongrout
force-pushed
the
python-monorepo
branch
from
2b2b52f
to
b6e07bc
Compare
|
I'm rebasing my new devinstall github workflow to be before my fixes to make sure that it fails, then I'll force push my fix again. |
|
Yay, the new dev-install workflow fails without the fix! |
|
Thanks for pushing this forward @jtpio! |
|
Nice! |
Since the ipywidgets repo is also a monorepo of Python packages, this change moves the Python packages to the
py/:py/ipywidgetspy/widgetsnbextensionpy/jupyterlab_widgetsThis came up during the weekly meeting yesterday when discussing the release process and adtopting the release:
While there are still a couple of open questions before being able to adopt the releaser, doing this move should be safer and could be merged before.