Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tty status function location #86

Closed
MCWertGaming opened this issue Feb 12, 2021 · 2 comments
Closed

tty status function location #86

MCWertGaming opened this issue Feb 12, 2021 · 2 comments

Comments

@MCWertGaming
Copy link
Collaborator

We already dicussed in #68 that we could move is_stdin_a_tty() and is_stdout_a_tty() outside of the class. As it is already a static member, no object is required. It's just a question of preference. What do you think? Rather leave everything as it is, or rather move both functions out of the class into the namespace?

@certik
Copy link
Collaborator

certik commented Feb 13, 2021 via email

@MCWertGaming
Copy link
Collaborator Author

Fixed in #132.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants