You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We already dicussed in #68 that we could move is_stdin_a_tty() and is_stdout_a_tty() outside of the class. As it is already a static member, no object is required. It's just a question of preference. What do you think? Rather leave everything as it is, or rather move both functions out of the class into the namespace?
The text was updated successfully, but these errors were encountered:
On Fri, Feb 12, 2021, at 4:44 PM, Damon Leven wrote:
We already dicussed in #68
<#68> that we could
move is_stdin_a_tty() and is_stdout_a_tty() outside of the class. As it
is already a static member, no object is required. It's just a question
of preference. What do you think? Rather leave everything as it is, or
rather move both functions out of the class into the namespace?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#86>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAFAWHIYKOO35DTH5OY4JTS6W4NDANCNFSM4XRQLYKA>.
We already dicussed in #68 that we could move is_stdin_a_tty() and is_stdout_a_tty() outside of the class. As it is already a static member, no object is required. It's just a question of preference. What do you think? Rather leave everything as it is, or rather move both functions out of the class into the namespace?
The text was updated successfully, but these errors were encountered: