Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

Scala support does not support serializing booleans #78

Closed
lbustelo opened this issue Nov 2, 2015 · 1 comment
Closed

Scala support does not support serializing booleans #78

lbustelo opened this issue Nov 2, 2015 · 1 comment

Comments

@lbustelo
Copy link
Collaborator

lbustelo commented Nov 2, 2015

@vinomaster hit this problem on his demo notebook. If we do something like

channel().set("aVar", false)

or

channel().set("aVar", true)

They are getting sent to the browser as strings. We cannot then use them as expected in a <template is='dom-if'>.

The problem is https://github.com/jupyter-incubator/declarativewidgets/blob/master/kernel-scala/src/main/scala/urth/widgets/util/SerializationSupport.scala#L27 is missing a case of Boolean and converting to JsBoolean.

/cc @wellecks

@lbustelo
Copy link
Collaborator Author

lbustelo commented Nov 3, 2015

I'm working on this one

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant