Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky windows tests #157

Open
akhmerov opened this issue Aug 27, 2020 · 6 comments
Open

Fix flaky windows tests #157

akhmerov opened this issue Aug 27, 2020 · 6 comments
Labels

Comments

@akhmerov
Copy link
Member

There's a warning about IOPub timeout and the failures are nondeterministic.

@choldgraf
Copy link
Contributor

perhaps the hackiest-but-fastest thing to do is to add a couple of catches to re-run this test if it fails with that error automatically. That way the test would only fail if it fails 3 times in a row or something

@akhmerov
Copy link
Member Author

akhmerov commented Sep 21, 2020

NB This seems to be the same issue: mwouts/jupytext#489

The solution from jupytext side was to skip all tests that execute notebooks on windows...

@chrisjsewell
Copy link
Contributor

theres a pytest plugin for that: https://github.com/pytest-dev/pytest-rerunfailures

@chrisjsewell
Copy link
Contributor

but the more complete fix would be to add an IOPub timeout option to parse to nbclient

@akhmerov
Copy link
Member Author

Didn't seem to help on jupytext side: mwouts/jupytext#489 (reference)

There's a draft PR against nbconvert, that claims to fix this jupyter/nbconvert#1183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants