Updatable Displays #225
Merged
Updatable Displays #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should |
|
(For |
Ah yes, that's important. |
willingc
reviewed
Nov 14, 2016
| ``display_data`` or ``execute_result``. | ||
|
|
||
| When a ``display_id`` is specified for a display, it can be updated later | ||
| with an ``update_display_data`` message. This message has the same format as `display_data`_ |
There was a problem hiding this comment.
Double check the '`' and triple backticks in this line and the next. Looks like some typos.
There was a problem hiding this comment.
Oops, that's my complete markdown bias showing. I've completely forgotten how to write restructured text.
willingc
reviewed
Nov 14, 2016
| 'data' : dict, | ||
|
|
||
| # Any metadata that describes the data | ||
| 'metadata' : dict |
willingc
reviewed
Nov 14, 2016
|
|
||
| # Any information not to be persisted to a notebook or other environment | ||
| # Intended to live only during a kernel session | ||
| 'transient': dict |
|
This is good to go and/or have some more review. |
minrk
reviewed
Nov 15, 2016
| Update Display Data | ||
| ------------------- | ||
|
|
||
| Displays can now be named with a ``display_id`` within the ``transient`` field of |
There was a problem hiding this comment.
Can you add .. versionadded:: 5.1 here?
| transient = { | ||
| 'display_id': 'abcd' | ||
| } | ||
|
|
||
| .. versionchanged:: 5.0 | ||
|
|
||
| `application/json` data should be unpacked JSON data, | ||
| not double-serialized as a JSON string. |
There was a problem hiding this comment.
add .. versionchanged:: 5.1 note for when transient will arrive
|
@minrk Thanks, updated! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The protocol updates for #209, updateable displays.
display_idintent