-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jupyter progress bar creates infinite copies at 0% #1426
Comments
Can you try with the current master? (Containing PR #1380.) |
That's what breaks it. The above shows the difference before/after PR #1380 (i.e., the difference between |
Ah sorry, I misread and thought you were using the release version. Do you have a |
Also, which browser are you using? |
I assume this is the version of your notebook server? (The Jupyter meta package on PyPI is only 1.0.0.) |
You could also check the developer/JS console of your browser for error messages. It works for me in Chrome and Firefox with |
I haven't added/customized a
Chrome Version 65.0.3325.181 (Official Build) (64-bit)
Yep.
This works for me as well!
Same here. Since upgrading, if I try to go back to
Sorry, I should have checked this before trying to upgrade, now that I can no longer downgrade. There was not anything in the server logs, however. |
I got |
Even this basic code isn't working for me: from IPython.display import ProgressBar
pb = ProgressBar(10)
h = display(pb, display_id=True)
pb.progress = 5
h.update(pb) So this might come down to Jupyter notebook bug rather than a Nengo bug. |
Ok, so I did some research and apparently update-able outputs where only introduced in Jupyter client/notebook 5.0 (jupyter/notebook#1879, jupyter/jupyter_client#225). I am probably not going to invest time in trying to make it work with older versions. |
Can it be updated to use the old progress bar if the version isn't right? That still worked for me. Or raise a warning telling them what to update? I'd be surprised if I was the only one using an older Jupyter/etc. Thanks for looking into this! |
I can't get it to work right now ... there is no The old progress bar also completely breaks the notebook (not just the progress bar) in the See #1087 for more discussion about dropping support for older notebook versions. You still have the option to switch to the terminal progress bar (for really old IPython notebook versions this can lead to a large memory consumption and notebook size; for those, the progress bar should be completely disabled). A message in unsupported notebook versions would be nice, but at the moment I cannot think of a way to achieve that. |
Take a look at #1428. It implements a warning message for older notebook versions (apparently the notebook version can be checked in Javascript). I'm not sure if that addresses/fixes the original issue as I never experienced the repeated progress bars. |
So I can't exactly try without setting up a new env. Was hoping someone else would run into this before I tried to reproduce from a virtual env. |
I never managed to reproduce the problem and I suppose no one else had it either. |
I am okay with this being closed under "cannot reproduce". Thanks for looking into it and figuring out the fix (upgrading |
We do not support progress bars in Jupyter notebook<5. Addresses #1426.
If I checkout
nengo==2.7.0
, everything works using the progress bar in this style:However, checking out the current commit on master, any simulation that takes longer than a couple of seconds will keep making copies of the progress bar at
0%
. Copies continue to be made for as long as it is building, and for as long as it is simulating (a few each second). This slows everything down substantially.Versions:
The text was updated successfully, but these errors were encountered: