Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The use of nest_asyncio makes nbconvert --to webpdf hang when used with --execute #108

Open
SylvainCorlay opened this issue Sep 20, 2020 · 3 comments

Comments

@SylvainCorlay
Copy link
Member

SylvainCorlay commented Sep 20, 2020

This comes with an issue in pyppeteer: pyppeteer/pyppeteer#99

How could we avoid using nest_asyncio for nbconvert --execute?

@davidbrochart
Copy link
Member

Instead of using execute() in nbconvert, we could use async_execute() and make it run until complete ourselves.
The problem is that execute() calls run_sync(), which creates an event loop the first time, and next time uses nest_asyncio, but it doesn't have to be (we could just get the current event loop). I think we should have a global option to use nest_asyncio or not.

@davidbrochart
Copy link
Member

I think this fixes the issue: jupyter/nbconvert#1406

@SylvainCorlay
Copy link
Member Author

I reported the issue in nest-asyncio and it seems that they fixed it right away: erdewit/nest_asyncio#34

If they make a patch release including this, we should require it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants