Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FutureWarning with jupyter_client 6.1.5 #89

Open
GuillaumeFavelier opened this issue Jun 30, 2020 · 1 comment
Open

FutureWarning with jupyter_client 6.1.5 #89

GuillaumeFavelier opened this issue Jun 30, 2020 · 1 comment

Comments

@GuillaumeFavelier
Copy link

Since the release of jupyter_client 6.1.5 we obtain a FutureWarning on mne-python in our CIs:

FutureWarning: Method cleanup(connection_file=True) is deprecated, use cleanup_resources(restart=False).
More details
../../../miniconda/lib/python3.7/site-packages/nbclient/client.py:471: in async_setup_kernel
    await self._async_cleanup_kernel()
        cleanup_kc = True
        kwargs     = {}
        loop       = <_UnixSelectorEventLoop running=False closed=False debug=False>
        on_signal  = <function NotebookClient.async_setup_kernel.<locals>.on_signal at 0x7ff5361314d0>
        self       = <nbclient.client.NotebookClient object at 0x7ff538282790>
../../../miniconda/lib/python3.7/site-packages/nbclient/client.py:346: in _async_cleanup_kernel
    await ensure_async(self.km.cleanup())
        now        = False
        self       = <nbclient.client.NotebookClient object at 0x7ff538282790>
../../../miniconda/lib/python3.7/site-packages/jupyter_client/manager.py:358: in cleanup
    FutureWarning)
E   FutureWarning: Method cleanup(connection_file=True) is deprecated, use cleanup_resources(restart=False).
@MSeal
Copy link
Contributor

MSeal commented Jun 30, 2020

Yes, the method was deprecated with some improvements made to the underlying models. It's just a warning for now, but will disappear in some future minor
or major release (shouldn't be anytime soon).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants