Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running | Notebooks | Shutdown buttons not working, fix found #4865

Closed
chrislnorth opened this issue Sep 4, 2019 · 14 comments · Fixed by #4939
Closed

Running | Notebooks | Shutdown buttons not working, fix found #4865

chrislnorth opened this issue Sep 4, 2019 · 14 comments · Fixed by #4939

Comments

@chrislnorth
Copy link

I found that if i change this code in static/tree/js/main.min.js:

        .click(function() {
            var path = $(this).parent().parent().parent().data('path');
            that.shutdown_notebook(path);
        })

to:

        .click(function() {
            var path = $(this).parent().parent().parent().parent().data('path');
            that.shutdown_notebook(path);
        })

then the Shutdown buttons work. Needs one more .parent() link in the chain.

jupyter --version
jupyter core : 4.5.0
jupyter-notebook : 6.0.0
qtconsole : 4.5.4
ipython : 5.8.0
ipykernel : 5.1.2
jupyter client : 5.3.1
jupyter lab : 1.0.2
nbconvert : 5.5.0
ipywidgets : 7.5.1
nbformat : 4.4.0
traitlets : 4.3.2

MacOS 10.13.6
Safari 12.1.12

Hope that helps.

@slumbi
Copy link

slumbi commented Sep 13, 2019

I confirm, it works for me too

@fboerman
Copy link

I can confirm to have the same problem

@MBlistein
Copy link

I can confirm both problem and fix, thanks for that!

@paxtonfitzpatrick
Copy link

Can also confirm both problem and fix! Thanks @chrislnorth!

jupyter --version:

jupyter core     : 4.5.0
jupyter-notebook : 6.0.1
qtconsole        : 4.5.5
ipython          : 7.8.0
ipykernel        : 5.1.2
jupyter client   : 5.3.3
jupyter lab      : 1.1.4
nbconvert        : 5.6.0
ipywidgets       : 7.5.1
nbformat         : 4.4.0
traitlets        : 4.3.2

Also,

macOS 10.14.5
Chrome 76.0.3809.132 (Official Build) (64-bit)

@rgbkrk
Copy link
Member

rgbkrk commented Oct 2, 2019

Filed #4939 as a fix.

@istavnit
Copy link

I found that if i change this code in static/tree/js/main.min.js:

        .click(function() {
            var path = $(this).parent().parent().parent().data('path');
            that.shutdown_notebook(path);
        })

to:

        .click(function() {
            var path = $(this).parent().parent().parent().parent().data('path');
            that.shutdown_notebook(path);
        })

then the Shutdown buttons work. Needs one more .parent() link in the chain.

jupyter --version
jupyter core : 4.5.0
jupyter-notebook : 6.0.0
qtconsole : 4.5.4
ipython : 5.8.0
ipykernel : 5.1.2
jupyter client : 5.3.1
jupyter lab : 1.0.2
nbconvert : 5.5.0
ipywidgets : 7.5.1
nbformat : 4.4.0
traitlets : 4.3.2

MacOS 10.13.6
Safari 12.1.12

Hope that helps.

In which folder this static/tree folder can be found on windows?

@lrlthink
Copy link

lrlthink commented Jan 6, 2020

I found that if i change this code in static/tree/js/main.min.js:

        .click(function() {
            var path = $(this).parent().parent().parent().data('path');
            that.shutdown_notebook(path);
        })

to:

        .click(function() {
            var path = $(this).parent().parent().parent().parent().data('path');
            that.shutdown_notebook(path);
        })

then the Shutdown buttons work. Needs one more .parent() link in the chain.

jupyter --version
jupyter core : 4.5.0
jupyter-notebook : 6.0.0
qtconsole : 4.5.4
ipython : 5.8.0
ipykernel : 5.1.2
jupyter client : 5.3.1
jupyter lab : 1.0.2
nbconvert : 5.5.0
ipywidgets : 7.5.1
nbformat : 4.4.0
traitlets : 4.3.2

MacOS 10.13.6
Safari 12.1.12

Hope that helps.

How to fix this bug after install by conda install?

@fboerman
Copy link

fboerman commented Jan 6, 2020

It has already been fixed in a new release. upgrade your notebook version to the latest

@istavnit
Copy link

istavnit commented Jan 6, 2020 via email

@XonFire
Copy link

XonFire commented Jan 25, 2020

It works thank you so much!!
just search for static/tree/js/main.min.js in your Anaconda3 folder and edit it with notepad

@TomLin
Copy link

TomLin commented Apr 12, 2020

It has already been fixed in a new release. upgrade your notebook version to the latest

Actually I tried to reinstall the package using pip install -U jupyter, but the bug still exists. I could only fix the problem by manually modifying the code in static/tree/js/main.min.js as instructed by @chrislnorth.

@DennisvdPluijm
Copy link

It has already been fixed in a new release. upgrade your notebook version to the latest

Actually I tried to reinstall the package using pip install -U jupyter, but the bug still exists. I could only fix the problem by manually modifying the code in static/tree/js/main.min.js as instructed by @chrislnorth.

Are you sure you have the latest version? I just upgraded from 6.0.0 to 6.1.0, the bug has been fixed in the latest version.
[note: for Anaconda I had to use conda-forge, otherwise it wouldn't update to 6.1.0]

@nealmcb
Copy link

nealmcb commented Aug 4, 2020

@TomLin I had to pip install -U notebook to get the upgrade to 6.1.1.

FWIW, I was also confused by the variety of package versions reported by jupyter --version, and the fact that it reports a version there for jupyter-notebook, but there is no package by that name in pypi.

$ jupyter --version
jupyter core     : 4.6.1
jupyter-notebook : 6.1.1
...

@kevin-bates
Copy link
Member

@nealmcb - thanks for providing the upgrade tip.

Regarding the jupyter command, this doesn't produce a list of packages, but rather a list of commands and their respective versions. It resides in the jupyter_core package. For the --version argument, it essentially walks a well-known list of jupyter packages and produces their version information prefixed by the corresponding command.

Since you thought these were packages, others probably do as well. It might make for a helpful contribution to include the package name in this output or allow for another option to --version which produces this information. Since there may be scripts consuming this output, something like jupyter --packages, that produces the same output but with package names, might be helpful. At any rate, this would be something to take up in jupyter_core if you (or anyone else) is interested.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.