Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to shutdown notebooks from running tab in notebook>=6.0.0 #5033

Closed
mpacer opened this issue Nov 6, 2019 · 4 comments
Closed

Impossible to shutdown notebooks from running tab in notebook>=6.0.0 #5033

mpacer opened this issue Nov 6, 2019 · 4 comments

Comments

@mpacer
Copy link
Member

mpacer commented Nov 6, 2019

When going to /tree#running there is a listing of notebooks as well as a shutdown button for each notebook
image

if I click Shutdown it should send a DELETE request & get back a 204 No Content response from the sessions API. Removing the notebooks session from the listing

image

As of notebook>=6.0.0 clicking the shutdown Button doesn't even trigger the request to the sessions API. As a result it is impossible to shut down notebooks from the Running tab.

This works in 5.7.8 and so would be a regression.

@dbrucknr
Copy link

dbrucknr commented Nov 15, 2019

I noticed this issue as well.

I'm not an experienced developer, but I was poking around in the source files for anaconda and discovered three files that looked promising:

/anaconda3/bin/launch_instance
/anaconda3/bin/list_instances
/anaconda3/bin/kill_instance

Since this issue is open, can anyone verify whether these files are relevant to a resolution?
*Edit - I think these files may be related to launching an EC2 Instance.

@jacksonloper
Copy link

jacksonloper commented Nov 25, 2019

This is indeed broken on, e.g. the docker image jupyter/datascience-notebook with sha sha256:b67b73237f92c5207c03cc758d8ebb0de281e33fc0c6836c1c6afe27950d3f72 running Chrome 78.0.3904.108 (Official Build) (64-bit) on Ubuntu.

@rgbkrk
Copy link
Member

rgbkrk commented Dec 17, 2019

Is this the same as #4865, which was fixed in #4939?

@mpacer
Copy link
Member Author

mpacer commented Dec 17, 2019

Fantastic, great catch @rgbkrk!

@mpacer mpacer closed this as completed Dec 17, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants