Store codemirror config in only one location #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes (once backported) #EntropyOrg/p5-Devel-IPerl#40 and jupyter#88
Carreau
added a commit
to Carreau/ipython
that referenced
this pull request
May 13, 2015
fix highlighting of non-python kernels.
Carreau
added a commit
to Carreau/ipython
that referenced
this pull request
May 13, 2015
fix highlighting of non-python kernels. mock the cm_config property also when set, unlike in non backported version of this PR
| // backward compat. | ||
| Object.defineProperty(this, 'cm_config', { | ||
| get: function() { | ||
| console.warn("warning you are accessing a deprecated field") |
There was a problem hiding this comment.
Does console.warn() say which file & line the warning came from? If not, this message should be more specific.
There was a problem hiding this comment.
It depends on the browser. But usually you get the file and line-number on the left side of the developper console.
|
I got half way through converting the cell classes to the new config system, but didn't manage to finish. I must get back to that at some point, but this looks like a reasonable compromise for the moment. |
minrk
added a commit
that referenced
this pull request
May 14, 2015
Store codemirror config in only one location
Carreau
added a commit
to Carreau/ipython
that referenced
this pull request
May 24, 2015
fix highlighting of non-python kernels. mock the cm_config property also when set, unlike in non backported version of this PR
minrk
added a commit
to ipython/ipython
that referenced
this pull request
May 24, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes (once backported) EntropyOrg/p5-Devel-IPerl#40
and #88