Specify minimum version of nbconvert required #6286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: GitHub Action <41898282+github-actions[bot]@users.noreply.github.com>
SHA256 hashes: notebook-6.4.8-py3-none-any.whl: 3e702fcc54b8ae597533c3864793b7a1e971dec9e112f67235828d8a798fd654 notebook-6.4.8.tar.gz: 1e985c9dc6f678bdfffb9dc657306b5469bfa62d73e03f74e8defbf76d284312
|
Pinging some of the people associated with the aforementioned PRs: @mdboom @minrk @takluyver Can someone review this PR? |
|
@Zsailer it seems like the change of base branch introduced additional changes beyond what was originally in the PR, is that okay or should I create a new branch off of 6.4.x? |
|
We pulled in the other commits in #6308, I'll try a Squash and merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 5.5.0 release of notebook introduced an import of
nbconvert.exporters.base(#3323). However, this feature was not introduced until nbconvert 5.0.0 (jupyter/nbconvert#423). This PR properly documents the minimum version of nbconvert required by notebook.Fixes #3629