Replace current_ip and current_port by ip and port #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 11, 2019
Merged
rkdarst
added a commit
to rkdarst/batchspawner
that referenced
this pull request
Jun 14, 2019
- jupyterhub#139 changes port handling, this makes tests pass. - Sets attribute mock_port, which gets used during the port polling phase.
rkdarst
added a commit
to rkdarst/batchspawner
that referenced
this pull request
Jun 14, 2019
- Fixes tests for PR jupyterhub#139
|
The top two commits in my pranch pr139_update fix tests here. What do you think, is there a better way to fix this? I've included this in my #143 now, but feel free to take it into here too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combined with jupyterhub/wrapspawner#27, it solves the issue mentioned in #103, #127 and #132.
It also paves the way to support named servers by generalizing the batchspawner api.