Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation of #58, selecting the port on the remote side #130

Merged
merged 2 commits into from
Jul 24, 2019

Conversation

rkdarst
Copy link
Contributor

@rkdarst rkdarst commented Feb 2, 2019

Fixes documentation for remote port selection.

- importing batchspawner.api could become depreciated in the future,
  but importing "batchspawner" will always work (and imports .api
  within it).  Recommend only importing batchspawner then.
- Add clarifying comment in one of the docs.
rkdarst added a commit to rkdarst/batchspawner that referenced this pull request Jul 16, 2019
@mbmilligan mbmilligan merged commit 7539961 into jupyterhub:master Jul 24, 2019
mbmilligan added a commit that referenced this pull request Jul 24, 2019
@rkdarst rkdarst deleted the portselection_doc branch September 6, 2019 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to import batchspawner.api in jupyterhub_config.py
2 participants