Allow batchspawner to be used with different notebook singleuser cmd #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of creating a batchspawner notebook app, batchspawner-singleuser is now a wrapper that finds a port and add the port number to the command-line argument of the singleuser app. This allows the usage of batchspawner with jupyterlab for example.
This was referenced Jun 11, 2019
Merged
rkdarst
added a commit
to rkdarst/batchspawner
that referenced
this pull request
Jun 14, 2019
…apper - This fixes up tests for jupyterhub#141, which adds batchspawner-singleuser which changes regular expressions that need to be matched in the batch scripts.
|
My branch https://github.com/rkdarst/batchspawner/commits/pr141_update seems to fix tests on this. I'm including it in my #143 but feel free to include it here too (I'm not maintainer so can't push directly). |
This was referenced Jun 16, 2019
rkdarst
added a commit
to rkdarst/batchspawner
that referenced
this pull request
Jun 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of creating a batchspawner notebook app, batchspawner-singleuser
is now a wrapper that finds a port and add the port number to the
command-line argument of the singleuser app. This allows the usage
of batchspawner with jupyterlab for example.