Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images are not optional #3

Closed
jacobtomlinson opened this issue Mar 27, 2018 · 0 comments
Closed

Images are not optional #3

jacobtomlinson opened this issue Mar 27, 2018 · 0 comments

Comments

@jacobtomlinson
Copy link
Contributor

First I want to say awesome project!

I'm trying to build a chart repo which currently doesn't have any images. The README says images are optional however I am unable to get it to run without them.

If I omit imagePrefix and images I get:

Traceback (most recent call last):
  File "/opt/boxen/homebrew/bin/chartpress", line 11, in <module>
    load_entry_point('chartpress==0.2.0.dev0', 'console_scripts', 'chartpress')()
  File "/opt/boxen/homebrew/Cellar/python3/3.6.3/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/chartpress.py", line 204, in main
    prefix=chart['imagePrefix'],
  File "/opt/boxen/homebrew/Cellar/python3/3.6.3/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/ruamel/yaml/comments.py", line 702, in __getitem__
    return ordereddict.__getitem__(self, key)
KeyError: 'imagePrefix'

If I set imagePrefix then I get:

Traceback (most recent call last):
  File "/opt/boxen/homebrew/bin/chartpress", line 11, in <module>
    load_entry_point('chartpress==0.2.0.dev0', 'console_scripts', 'chartpress')()
  File "/opt/boxen/homebrew/Cellar/python3/3.6.3/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/chartpress.py", line 205, in main
    images=chart['images'],
  File "/opt/boxen/homebrew/Cellar/python3/3.6.3/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/ruamel/yaml/comments.py", line 702, in __getitem__
    return ordereddict.__getitem__(self, key)
KeyError: 'images'

If I set images to None I get:

Traceback (most recent call last):
  File "/opt/boxen/homebrew/bin/chartpress", line 11, in <module>
    load_entry_point('chartpress==0.2.0.dev0', 'console_scripts', 'chartpress')()
  File "/opt/boxen/homebrew/Cellar/python3/3.6.3/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/chartpress.py", line 208, in main
    push=args.push,
  File "/opt/boxen/homebrew/Cellar/python3/3.6.3/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/chartpress.py", line 65, in build_images
    for name, options in images.items():
AttributeError: 'NoneType' object has no attribute 'items'

If I set images to an empty list (images: []) I get:

Traceback (most recent call last):
  File "/opt/boxen/homebrew/bin/chartpress", line 11, in <module>
    load_entry_point('chartpress==0.2.0.dev0', 'console_scripts', 'chartpress')()
  File "/opt/boxen/homebrew/Cellar/python3/3.6.3/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/chartpress.py", line 208, in main
    push=args.push,
  File "/opt/boxen/homebrew/Cellar/python3/3.6.3/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/chartpress.py", line 65, in build_images
    for name, options in images.items():
AttributeError: 'CommentedSeq' object has no attribute 'items'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant