updated websecurity.md #4083
Merged
updated websecurity.md #4083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have the grammatical errors written on the page such as improving the abbreviated words with apostrophes and other typos
GeorgianaElena
added
needs: review
outreachy-dec22
minrk
reviewed
Oct 12, 2022
docs/source/reference/websecurity.md
Outdated
|
|
||
| This overview also helps you obtain a deeper understanding of how JupyterHub | ||
| works. | ||
|
|
||
| ## Semi-trusted and untrusted users | ||
| ## Semi-trusted and Untrusted Users |
There was a problem hiding this comment.
Let's keep sentence case in headings for consistency (if you see any Title Case, feel free to fix them to Sentence case)
docs/source/reference/websecurity.md
Outdated
|
|
||
| JupyterHub is designed to be a _simple multi-user server for modestly sized | ||
| groups_ of **semi-trusted** users. While the design reflects serving semi-trusted | ||
| users, JupyterHub is not necessarily unsuitable for serving **untrusted** users. | ||
|
|
||
| Using JupyterHub with **untrusted** users does mean more work by the | ||
| Using JupyterHub with **untrusted** users entails more work by the |
There was a problem hiding this comment.
I think "does mean" hits this point better than "entails"
docs/source/reference/websecurity.md
Outdated
| @@ -41,7 +41,7 @@ To protect all users from each other, JupyterHub administrators must | |||
| ensure that: | |||
|
|
|||
| - A user **does not have permission** to modify their single-user notebook server, | |||
| including: | |||
| as well as: | |||
There was a problem hiding this comment.
This is not "in addition to," it is examples of what "does not have permission to modify their single-user notebook server" means, specifically.
| @@ -129,7 +129,7 @@ A handy website for testing your deployment is | |||
|
|
|||
| ## Vulnerability reporting | |||
|
|
|||
| If you believe you’ve found a security vulnerability in JupyterHub, or any | |||
| If you believe you have found a security vulnerability in JupyterHub, or any | |||
I resolved my previous commit as suggested
|
Congrats on your first merged pull request in this project! 🎉 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I improved the grammatical errors written on the page such as improving the abbreviated words with apostrophes and other typos