Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: sphinx config cleanup, removing epub build, fix build warnings #4222

Merged
merged 4 commits into from
Nov 17, 2022

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Nov 17, 2022

  • docs: remove unused alabaster_jupyterhub requirement
  • docs: cleanup unused config for htmlhelp, latex, manual
  • docs: remove epub documentation build
  • docs: fix broken links and formatting errors

We don't have ePub builds in other projects, and I don't know of anyone using them. Due to that, I suggest we reduce the complexity and remove it here as well. It is not much of a complexity compared to the PDF build already removed, but its notable.

The RTD v2 config defaults to not providing ePub builds, but we are currently opting in to it. I suggest we opt out now to reduce complexity sooner rather than later if something breaks in the future, like what happened for the PDF build if I recall correctly.

Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks!

@minrk minrk merged commit ffbc981 into jupyterhub:main Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants