Delete pod if it already exists before attempting to start it again #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now only pay for extra API calls when we do encounter failures, not on every start
|
Tested locally, seems to work! I tested this by creating a bogus pod that has a name that JupyterHub will want to use, but is stuck in a non-running state (easiest way is to use a false image name, which gets it stuck in ErrImagePull). Then try starting the pod - it should kill the bogus existing pod and start a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will kill old pods that JupyterHub has lost track of or haven't started in time, and kill them before attempting to start a new pod.