Delete remnant now unused parts in spawner.py #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
requested changes
Nov 29, 2019
bitnik
force-pushed
the
patch-1
branch
2 times, most recently
from
41c1713
to
b248128
Compare
consideRatio
approved these changes
Dec 17, 2019
|
IMO, we should delete the code if it isn't being used - we can always revert it from version control - rather than comment it out. Cleaner |
|
@bitnik I'm sorry for grinding this PR to a halt. We should indeed remove outdated parts. I force rebased commit with proper deletions after looking into this sufficiently enough to feel confident that I wouldn't loose important insights about the logic by doing so. Thank you @yuvipanda for your input, I agree, sorry for slowing this down everyone!
|
consideRatio
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.