Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the errors followed by the contributing steps #509

Merged
merged 3 commits into from Jun 4, 2021
Merged

Fix the errors followed by the contributing steps #509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32887a2
Fix the erros followed by the contributing steps
Jun 2, 2021
d033bb0
fix pre-commit error
Jun 2, 2021
1275e07
fix pre-commit error
consideRatio Jun 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Expand Up @@ -75,3 +75,6 @@ docs/source/build/

# PyBuilder
target/

# Pycharm
.idea/
5 changes: 2 additions & 3 deletions jupyterhub_config.py
View file
Open in desktop
@@ -1,7 +1,6 @@
import os
import socket


c.JupyterHub.spawner_class = 'kubespawner.KubeSpawner'

c.JupyterHub.ip = '127.0.0.1'
Expand All @@ -17,7 +16,7 @@
# Our simplest user image! Optimized to just... start, and be small!
c.KubeSpawner.image = 'jupyterhub/singleuser:1.0'

if os.env.get("CI"):
if os.environ.get("CI"):
# In the CI system we use k3s which will be accessible on localhost.
c.JupyterHub.hub_connect_ip = "127.0.0.1"
else:
Expand All @@ -32,7 +31,7 @@

c.KubeSpawner.service_account = 'default'
# Do not use any authentication at all - any username / password will work.
c.JupyterHub.authenticator_class = 'dummyauthenticator.DummyAuthenticator'
c.JupyterHub.authenticator_class = 'dummy'

c.KubeSpawner.storage_pvc_ensure = False

Expand Down