Fix hard-coded component label for services_enabled=True #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolfinus
force-pushed
the
service_component_name
branch
from
835c315
to
b38a63b
Compare
dolfinus
changed the title
dolfinus
force-pushed
the
service_component_name
branch
2 times, most recently
from
a5a171a
to
89e645c
Compare
dolfinus
force-pushed
the
service_component_name
branch
3 times, most recently
from
4c6f4ab
to
a700718
Compare
dolfinus
force-pushed
the
service_component_name
branch
2 times, most recently
from
5df58db
to
c6a76bc
Compare
dolfinus
commented
Nov 9, 2022
dolfinus
force-pushed
the
service_component_name
branch
from
c6a76bc
to
da764c2
Compare
dolfinus
commented
Nov 10, 2022
dolfinus
commented
Nov 10, 2022
consideRatio
force-pushed
the
service_component_name
branch
from
8e8e710
to
5e5cbd2
Compare
|
@dolfinus if this looks good to you, I suggest we go for a merge! Super thankful for your thorough work and wants to do what I can manage to help you retain a momentum!! |
consideRatio
approved these changes
Nov 10, 2022
|
Rocket approval :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've set up KubeSpawner with following settings:
But created services were not bound to the notebook pod because 'component' label is hard-coded in
make_servicefunction, and always havesingleuser-servervalue.Fixed that by moving selector build outside the
make_servicefunction.Added tests for custom
component_labelvalue passed with different values ofservices_enabled.